From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, ehabkost@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy()
Date: Mon, 23 Mar 2015 12:55:52 +0000 [thread overview]
Message-ID: <1427115352-4948-1-git-send-email-leon.alrae@imgtec.com> (raw)
New threads always point at the same env which is incorrect and usually leads
to a crash.
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
Hi,
This patch fixes the bug introduced in:
commit 2994fd96d986578a342f2342501b4ad30f6d0a85
Author: Eduardo Habkost <ehabkost@redhat.com>
cpu: Make cpu_init() return QOM CPUState object
Regards,
Leon
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 6e446de..04668e8 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -3453,7 +3453,7 @@ CPUArchState *cpu_copy(CPUArchState *env)
{
CPUState *cpu = ENV_GET_CPU(env);
CPUState *new_cpu = cpu_init(cpu_model);
- CPUArchState *new_env = cpu->env_ptr;
+ CPUArchState *new_env = new_cpu->env_ptr;
CPUBreakpoint *bp;
CPUWatchpoint *wp;
--
2.1.0
next reply other threads:[~2015-03-23 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:55 Leon Alrae [this message]
2015-03-23 13:02 ` [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy() Andreas Färber
2015-03-23 13:19 ` Andreas Färber
2015-03-23 13:23 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427115352-4948-1-git-send-email-leon.alrae@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).