From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@gmail.com, peter.crosthwaite@xilinx.com,
michael@walle.cc, armbru@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH for-2.3 v2 0/2] sdhci: add "drive" property
Date: Mon, 23 Mar 2015 15:55:36 +0100 [thread overview]
Message-ID: <1427122538-26060-1-git-send-email-pbonzini@redhat.com> (raw)
realize() methods aren't supposed to go on fishing expeditions for
backends. For this reason, "-drive if=" options (apart from if=none)
are only handled at board creation time, and is not affected by -device.
The right way for devices to tie themselves to a -drive option is
"-device sdhci-pci,drive=xyz". For 2.3 we can fix sdhci only, since
sdhci-pci is a new ABI. The others can wait for later.
Paolo
Paolo Bonzini (2):
sd: move blk_attach_dev_nofail to caller
sdhci: add "drive" property
hw/arm/xilinx_zynq.c | 11 ++++++++++-
hw/sd/milkymist-memcard.c | 3 +++
hw/sd/omap_mmc.c | 4 ++++
hw/sd/pl181.c | 7 ++++++-
hw/sd/pxa2xx_mmci.c | 4 ++++
hw/sd/sd.c | 1 -
hw/sd/sdhci.c | 6 ++----
hw/sd/sdhci.h | 1 +
hw/sd/ssi-sd.c | 7 ++++++-
9 files changed, 36 insertions(+), 8 deletions(-)
--
2.3.3
next reply other threads:[~2015-03-23 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 14:55 Paolo Bonzini [this message]
2015-03-23 14:55 ` [Qemu-devel] [PATCH for-2.3 v2 1/2] sd: move blk_attach_dev_nofail to caller Paolo Bonzini
2015-03-23 14:55 ` [Qemu-devel] [PATCH for-2.3 v2 2/2] sdhci: add "drive" property Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427122538-26060-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=michael@walle.cc \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).