From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya3lc-0007ay-Tk for qemu-devel@nongnu.org; Mon, 23 Mar 2015 10:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya3lY-0005lC-UW for qemu-devel@nongnu.org; Mon, 23 Mar 2015 10:55:48 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:33798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya3lY-0005kz-O8 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 10:55:44 -0400 Received: by wibg7 with SMTP id g7so36256323wib.1 for ; Mon, 23 Mar 2015 07:55:43 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 23 Mar 2015 15:55:36 +0100 Message-Id: <1427122538-26060-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH for-2.3 v2 0/2] sdhci: add "drive" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: edgar.iglesias@gmail.com, peter.crosthwaite@xilinx.com, michael@walle.cc, armbru@redhat.com, peter.maydell@linaro.org realize() methods aren't supposed to go on fishing expeditions for backends. For this reason, "-drive if=" options (apart from if=none) are only handled at board creation time, and is not affected by -device. The right way for devices to tie themselves to a -drive option is "-device sdhci-pci,drive=xyz". For 2.3 we can fix sdhci only, since sdhci-pci is a new ABI. The others can wait for later. Paolo Paolo Bonzini (2): sd: move blk_attach_dev_nofail to caller sdhci: add "drive" property hw/arm/xilinx_zynq.c | 11 ++++++++++- hw/sd/milkymist-memcard.c | 3 +++ hw/sd/omap_mmc.c | 4 ++++ hw/sd/pl181.c | 7 ++++++- hw/sd/pxa2xx_mmci.c | 4 ++++ hw/sd/sd.c | 1 - hw/sd/sdhci.c | 6 ++---- hw/sd/sdhci.h | 1 + hw/sd/ssi-sd.c | 7 ++++++- 9 files changed, 36 insertions(+), 8 deletions(-) -- 2.3.3