qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH v3 8/9] os-win32: drop ffs(3) prototype
Date: Mon, 23 Mar 2015 15:29:30 +0000	[thread overview]
Message-ID: <1427124571-28598-9-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1427124571-28598-1-git-send-email-stefanha@redhat.com>

The lack of ffs(3) in the MinGW headers is a hint that we shouldn't rely
on it.  MinGW 4.9.2 does not make it available for linking when QEMU's
./configure --enable-debug is used (release builds are fine though).

Now that all QEMU code has been switched to ctz32() there is no need for
ffs(3).

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/sysemu/os-win32.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h
index 9cc9e08..4035c4f 100644
--- a/include/sysemu/os-win32.h
+++ b/include/sysemu/os-win32.h
@@ -72,9 +72,6 @@
 #define sigsetjmp(env, savemask) setjmp(env)
 #define siglongjmp(env, val) longjmp(env, val)
 
-/* Declaration of ffs() is missing in MinGW's strings.h. */
-int ffs(int i);
-
 /* Missing POSIX functions. Don't use MinGW-w64 macros. */
 #undef gmtime_r
 struct tm *gmtime_r(const time_t *timep, struct tm *result);
-- 
2.1.0

  parent reply	other threads:[~2015-03-23 15:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 15:29 [Qemu-devel] [PATCH v3 0/9] Convert ffs(3) to ctz32() Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 1/9] bt-sdp: fix broken uuids power-of-2 calculation Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 2/9] hw/arm/nseries: convert ffs(3) to ctz32() Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 3/9] uninorth: " Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 4/9] Convert (ffs(val) - 1) to ctz32(val) Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 5/9] Convert ffs() != 0 callers to ctz32() Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 6/9] sd: convert sd_normal_command() ffs(3) call " Stefan Hajnoczi
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 7/9] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update() Stefan Hajnoczi
2015-03-23 15:40   ` Paolo Bonzini
2015-03-24 13:36     ` Stefan Hajnoczi
2015-03-23 15:29 ` Stefan Hajnoczi [this message]
2015-03-23 15:29 ` [Qemu-devel] [PATCH v3 9/9] checkpatch: complain about ffs(3) calls Stefan Hajnoczi
2015-03-25 13:09 ` [Qemu-devel] [PATCH v3 0/9] Convert ffs(3) to ctz32() Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427124571-28598-9-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).