From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya4Ic-0001fm-7Y for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:29:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya4Ib-00089z-BQ for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:29:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya4Ib-00089D-4Y for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:29:53 -0400 From: Stefan Hajnoczi Date: Mon, 23 Mar 2015 15:29:30 +0000 Message-Id: <1427124571-28598-9-git-send-email-stefanha@redhat.com> In-Reply-To: <1427124571-28598-1-git-send-email-stefanha@redhat.com> References: <1427124571-28598-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v3 8/9] os-win32: drop ffs(3) prototype List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster , Stefan Hajnoczi , Peter Maydell The lack of ffs(3) in the MinGW headers is a hint that we shouldn't rely on it. MinGW 4.9.2 does not make it available for linking when QEMU's ./configure --enable-debug is used (release builds are fine though). Now that all QEMU code has been switched to ctz32() there is no need for ffs(3). Signed-off-by: Stefan Hajnoczi --- include/sysemu/os-win32.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index 9cc9e08..4035c4f 100644 --- a/include/sysemu/os-win32.h +++ b/include/sysemu/os-win32.h @@ -72,9 +72,6 @@ #define sigsetjmp(env, savemask) setjmp(env) #define siglongjmp(env, val) longjmp(env, val) -/* Declaration of ffs() is missing in MinGW's strings.h. */ -int ffs(int i); - /* Missing POSIX functions. Don't use MinGW-w64 macros. */ #undef gmtime_r struct tm *gmtime_r(const time_t *timep, struct tm *result); -- 2.1.0