From: Ian Campbell <ian.campbell@citrix.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Kevin <kevin.tian@intel.com>,
wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com,
qemu-devel@nongnu.org, xen-devel@lists.xen.org,
stefano.stabellini@citrix.com
Subject: Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c
Date: Wed, 25 Mar 2015 10:26:50 +0000 [thread overview]
Message-ID: <1427279210.10784.49.camel@citrix.com> (raw)
In-Reply-To: <55120CEA.2020607@intel.com>
On Wed, 2015-03-25 at 09:18 +0800, Chen, Tiejun wrote:
> Actually my problem is that, I need to add a new parameter, 'flag', like
> this, xc_assign_device(xxx,xxx,flag). So if I don't refine xc.c, tools
> can't be compiled successfully. Or maybe you're suggesting I may isolate
> this file while building tools, right?
I answered this in my original reply:
it is acceptable for the new
parameter to not be plumbed up to the Python bindings until someone
comes along with a requirement to use it from Python. IOW you can just
pass whatever the nop value is for the new argument.
The "nop value" is whatever value should be passed to retain the current
behaviour.
Ian.
next prev parent reply other threads:[~2015-03-25 10:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 1:17 [Qemu-devel] [v3][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream Tiejun Chen
2015-03-23 1:17 ` [Qemu-devel] [v3][PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru Tiejun Chen
2015-03-23 1:17 ` [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind Tiejun Chen
2015-03-24 8:47 ` [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c Chen, Tiejun
2015-03-24 9:51 ` Ian Campbell
2015-03-24 10:15 ` Chen, Tiejun
2015-03-24 10:20 ` Ian Campbell
2015-03-24 10:31 ` Chen, Tiejun
2015-03-24 10:40 ` Ian Campbell
2015-03-25 1:18 ` Chen, Tiejun
2015-03-25 10:26 ` Ian Campbell [this message]
2015-03-26 0:44 ` Chen, Tiejun
2015-03-24 14:50 ` [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind Ian Campbell
2015-03-25 1:10 ` Chen, Tiejun
2015-03-25 10:32 ` Ian Campbell
2015-03-26 0:53 ` Chen, Tiejun
2015-03-26 10:06 ` Ian Campbell
2015-03-27 1:29 ` Chen, Tiejun
2015-03-27 9:54 ` Ian Campbell
2015-03-30 1:28 ` Chen, Tiejun
2015-03-30 9:19 ` Ian Campbell
2015-04-01 1:05 ` Chen, Tiejun
2015-04-01 8:45 ` Ian Campbell
2015-04-01 9:18 ` Chen, Tiejun
2015-04-01 9:53 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427279210.10784.49.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@citrix.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).