From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaiWY-0005LS-ON
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 06:26:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaiWU-0006nT-5m
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 06:26:58 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:15190)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaiWU-0006mO-0N
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 06:26:54 -0400
Message-ID: <1427279210.10784.49.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Wed, 25 Mar 2015 10:26:50 +0000
In-Reply-To: <55120CEA.2020607@intel.com>
References: <1427073466-16956-1-git-send-email-tiejun.chen@intel.com>
	<1427073466-16956-3-git-send-email-tiejun.chen@intel.com>
	<55112498.2040108@intel.com> <1427190704.21742.318.camel@citrix.com>
	<55113959.90600@intel.com> <1427192444.21742.330.camel@citrix.com>
	<55113CFD.1040406@intel.com> <1427193616.21742.333.camel@citrix.com>
	<55120CEA.2020607@intel.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] One question to lowlevel/xl/xl.c and
	lowlevel/xc/xc.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Kevin <kevin.tian@intel.com>, wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com

On Wed, 2015-03-25 at 09:18 +0800, Chen, Tiejun wrote:
> Actually my problem is that, I need to add a new parameter, 'flag', like 
> this, xc_assign_device(xxx,xxx,flag). So if I don't refine xc.c, tools 
> can't be compiled successfully. Or maybe you're suggesting I may isolate 
> this file while building tools, right?

I answered this in my original reply:
         it is acceptable for the new
        parameter to not be plumbed up to the Python bindings until someone
        comes along with a requirement to use it from Python. IOW you can just
        pass whatever the nop value is for the new argument.

The "nop value" is whatever value should be passed to retain the current
behaviour.

Ian.