From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaicN-0006lc-Ut
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 06:33:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaicJ-0001pk-Sb
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 06:32:59 -0400
Received: from smtp.citrix.com ([66.165.176.89]:45506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaicJ-0001pW-Nu
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 06:32:55 -0400
Message-ID: <1427279543.10784.53.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Wed, 25 Mar 2015 10:32:23 +0000
In-Reply-To: <55120B1C.5080004@intel.com>
References: <1427073466-16956-1-git-send-email-tiejun.chen@intel.com>
	<1427073466-16956-3-git-send-email-tiejun.chen@intel.com>
	<1427208618.21742.421.camel@citrix.com> <55120B1C.5080004@intel.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, qemu-devel@nongnu.org, stefano.stabellini@citrix.com, xen-devel@lists.xen.org

On Wed, 2015-03-25 at 09:10 +0800, Chen, Tiejun wrote:

> +But when given as a string the B<gfx_passthru> option describes the type
> +of device to enable. Not this behavior is only supported with upstream

"Note" and "the upstream..."

> +=item "igd"
> +
> +Enables graphics device PCI passthrough but force set the type of device
> +with the Intel Graphics Device.

"but force set the type" doesn't scan very well. "... forcing the type
of device to Intel Graphics Device" works I think.

> I understand what you mean but that table just includes IGDs existed on 
> BDW and HSW. Because in the case of qemu upstream we're just covering 
> these platforms, and with our discussion we don't have any plan to add 
> those legacy platforms in the future. But qemu-xen-traditional still 
> covers those platforms. So I'm afraid its not good to check this with 
> that table as well.

Hrm, OK. I suppose we can live with autodetect and igd both meaning igd
and whoever adds a new type will have to remember to add a check for
qemu-trad then.

Ian.