From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb4gv-0004DD-Os for qemu-devel@nongnu.org; Thu, 26 Mar 2015 06:07:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb4gr-0007FG-Eg for qemu-devel@nongnu.org; Thu, 26 Mar 2015 06:07:09 -0400 Received: from smtp.citrix.com ([66.165.176.89]:2217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb4gr-0007F8-9c for qemu-devel@nongnu.org; Thu, 26 Mar 2015 06:07:05 -0400 Message-ID: <1427364418.10784.122.camel@citrix.com> From: Ian Campbell Date: Thu, 26 Mar 2015 10:06:58 +0000 In-Reply-To: <551358A7.2090607@intel.com> References: <1427073466-16956-1-git-send-email-tiejun.chen@intel.com> <1427073466-16956-3-git-send-email-tiejun.chen@intel.com> <1427208618.21742.421.camel@citrix.com> <55120B1C.5080004@intel.com> <1427279543.10784.53.camel@citrix.com> <551358A7.2090607@intel.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Chen, Tiejun" Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, qemu-devel@nongnu.org, stefano.stabellini@citrix.com, xen-devel@lists.xen.org On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > > Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > > and whoever adds a new type will have to remember to add a check for > > qemu-trad then. > > > > When we really have to introduce a new type, this means we probably need > to change something inside qemu codes. So a new type should just go into > that table to support qemu upstream since now we shouldn't refactor > anything in qemu-xen-traditional, right? We'd want to error out on attempts to use qemu-xen-trad with non-IGD passthru. Ian.