From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH for-2.3 1/4] virtio-ccw: fix range check for SET_VQ
Date: Thu, 26 Mar 2015 16:35:59 +0100 [thread overview]
Message-ID: <1427384162-4994-2-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1427384162-4994-1-git-send-email-cornelia.huck@de.ibm.com>
VIRTIO_PCI_QUEUE_MAX is already too big; a malicious guest would be
able to trigger a write beyond the VirtQueue structure.
Cc: qemu-stable@nongnu.org
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/s390x/virtio-ccw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 130535c..ceb6a45 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -266,7 +266,7 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align,
{
VirtIODevice *vdev = virtio_ccw_get_vdev(sch);
- if (index > VIRTIO_PCI_QUEUE_MAX) {
+ if (index >= VIRTIO_PCI_QUEUE_MAX) {
return -EINVAL;
}
--
2.3.4
next prev parent reply other threads:[~2015-03-26 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 15:35 [Qemu-devel] [PATCH for-2.3 0/4] assorted s390x fixes Cornelia Huck
2015-03-26 15:35 ` Cornelia Huck [this message]
2015-03-27 9:04 ` [Qemu-devel] [PATCH for-2.3 1/4] virtio-ccw: fix range check for SET_VQ Christian Borntraeger
2015-03-26 15:36 ` [Qemu-devel] [PATCH for-2.3 2/4] virtio-ccw: range check in READ_VQ_CONF Cornelia Huck
2015-03-27 9:05 ` Christian Borntraeger
2015-03-26 15:36 ` [Qemu-devel] [PATCH for-2.3 3/4] s390x: do not include ram_addr.h Cornelia Huck
2015-03-27 13:04 ` Thomas Huth
2015-03-26 15:36 ` [Qemu-devel] [PATCH for-2.3 4/4] s390x/ipl: avoid sign extension Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427384162-4994-2-git-send-email-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).