From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb9pS-000403-Pj for qemu-devel@nongnu.org; Thu, 26 Mar 2015 11:36:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb9pL-0000Xx-A4 for qemu-devel@nongnu.org; Thu, 26 Mar 2015 11:36:18 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:47426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb9pL-0000Wq-0U for qemu-devel@nongnu.org; Thu, 26 Mar 2015 11:36:11 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2015 15:36:08 -0000 From: Cornelia Huck Date: Thu, 26 Mar 2015 16:35:59 +0100 Message-Id: <1427384162-4994-2-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1427384162-4994-1-git-send-email-cornelia.huck@de.ibm.com> References: <1427384162-4994-1-git-send-email-cornelia.huck@de.ibm.com> Subject: [Qemu-devel] [PATCH for-2.3 1/4] virtio-ccw: fix range check for SET_VQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Cornelia Huck , borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de, qemu-stable@nongnu.org VIRTIO_PCI_QUEUE_MAX is already too big; a malicious guest would be able to trigger a write beyond the VirtQueue structure. Cc: qemu-stable@nongnu.org Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 130535c..ceb6a45 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -266,7 +266,7 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align, { VirtIODevice *vdev = virtio_ccw_get_vdev(sch); - if (index > VIRTIO_PCI_QUEUE_MAX) { + if (index >= VIRTIO_PCI_QUEUE_MAX) { return -EINVAL; } -- 2.3.4