From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbBFl-0003R3-Vj for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:07:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbBFf-0006B7-Vx for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:07:33 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:33589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbBFf-0006Ay-Ox for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:07:27 -0400 Received: by pabxg6 with SMTP id xg6so68678759pab.0 for ; Thu, 26 Mar 2015 10:07:27 -0700 (PDT) Sender: Lin Ma From: Lin Ma Date: Fri, 27 Mar 2015 01:07:05 +0800 Message-Id: <1427389626-23487-2-git-send-email-lma@suse.com> In-Reply-To: <1427389626-23487-1-git-send-email-lma@suse.com> References: <1427389626-23487-1-git-send-email-lma@suse.com> Subject: [Qemu-devel] [PATCH v3 1/2] qom: Add can_be_deleted callback to UserCreatableClass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: imammedo@redhat.com, afaerber@suse.de, peter.crosthwaite@xilinx.com, pbonzini@redhat.com Cc: qemu-devel@nongnu.org, Lin Ma If backends implement the can_be_deleted and it returns false, Then the qmp_object_del won't delete the given backends. Signed-off-by: Lin Ma --- include/qom/object_interfaces.h | 3 +++ qmp.c | 13 +++++++++++++ 2 files changed, 16 insertions(+) diff --git a/include/qom/object_interfaces.h b/include/qom/object_interfaces.h index b792283..19b66f1 100644 --- a/include/qom/object_interfaces.h +++ b/include/qom/object_interfaces.h @@ -25,6 +25,8 @@ typedef struct UserCreatable { * UserCreatableClass: * @parent_class: the base class * @complete: callback to be called after @obj's properties are set. + * @can_be_deleted: callback to be called before an object is removed + * to check if @obj can be removed safely. * * Interface is designed to work with -object/object-add/object_add * commands. @@ -47,6 +49,7 @@ typedef struct UserCreatableClass { /* */ void (*complete)(UserCreatable *uc, Error **errp); + bool (*can_be_deleted)(UserCreatable *uc, Error **errp); } UserCreatableClass; /** diff --git a/qmp.c b/qmp.c index c479e77..a9156d6 100644 --- a/qmp.c +++ b/qmp.c @@ -711,6 +711,19 @@ void qmp_object_del(const char *id, Error **errp) error_setg(errp, "object id not found"); return; } + + UserCreatableClass *ucc; + UserCreatable *uc = + (UserCreatable *)object_dynamic_cast(obj, TYPE_USER_CREATABLE); + ucc = USER_CREATABLE_GET_CLASS(uc); + if (ucc->can_be_deleted) { + if (!ucc->can_be_deleted(uc, errp)) { + char *path = object_get_canonical_path_component(obj); + error_setg(errp, "%s is in used, can not be deleted", path); + g_free(path); + return; + } + } object_unparent(obj); } -- 2.1.4