From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbBFn-0003ST-7q for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:07:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbBFj-0006C9-G0 for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:07:35 -0400 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:36499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbBFj-0006C3-8R for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:07:31 -0400 Received: by pdbcz9 with SMTP id cz9so68438184pdb.3 for ; Thu, 26 Mar 2015 10:07:30 -0700 (PDT) Sender: Lin Ma From: Lin Ma Date: Fri, 27 Mar 2015 01:07:06 +0800 Message-Id: <1427389626-23487-3-git-send-email-lma@suse.com> In-Reply-To: <1427389626-23487-1-git-send-email-lma@suse.com> References: <1427389626-23487-1-git-send-email-lma@suse.com> Subject: [Qemu-devel] [PATCH v3 2/2] hostmem: Prevent removing an in-use memory backend object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: imammedo@redhat.com, afaerber@suse.de, peter.crosthwaite@xilinx.com, pbonzini@redhat.com Cc: qemu-devel@nongnu.org, Lin Ma showing a memory device whose memdev is removed leads an assert: (qemu) object_add memory-backend-ram,id=ram0,size=128M (qemu) device_add pc-dimm,id=d0,memdev=ram0 (qemu) object_del ram0 (qemu) info memory-devices ** ERROR:qom/object.c:1274:object_get_canonical_path_component:\ assertion failed: (obj->parent != NULL) Aborted The patch prevents removing an in-use mem backend and error out. Signed-off-by: Lin Ma --- backends/hostmem.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/backends/hostmem.c b/backends/hostmem.c index 99e8f99..dbf94a9 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -335,12 +335,26 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) } } +static bool +host_memory_backend_can_be_deleted(UserCreatable *uc, Error **errp) +{ + MemoryRegion *mr; + mr = host_memory_backend_get_memory(MEMORY_BACKEND(uc), errp); + if (memory_region_is_mapped(mr)) { + return false; + } else { + return true; + } +} + static void host_memory_backend_class_init(ObjectClass *oc, void *data) { UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); ucc->complete = host_memory_backend_memory_complete; + + ucc->can_be_deleted = host_memory_backend_can_be_deleted; } static const TypeInfo host_memory_backend_info = { -- 2.1.4