From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, mark.cave-ayland@ilande.co.uk,
armbru@redhat.com, hpoussin@reactos.org, qemu-ppc@nongnu.org,
jsnow@redhat.com, "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage
Date: Sun, 29 Mar 2015 19:53:15 +0200 [thread overview]
Message-ID: <1427651603-9210-1-git-send-email-afaerber@suse.de> (raw)
Hello Markus et al.,
This series attempts to fix the -device pc87312 issues you reported.
I can't add alias properties for devices that don't get created before realize.
Therefore this involves moving code for various ISA devices, to enable us
to initialize the objects early for alias properties and realizing them
as part of the composite device once the configuration is known, also fixing
error propagation while at it. Probably needs a further iteration.
Yes, it's terribly invasive, that's why the code was as it is.
But the code movements are quite trivial, as long as no in-air conflicts occur.
A follow-up would be to respin my old ISA enabled/disabled series to allow
inactive ISADevices sitting on an ISABus.
Regards,
Andreas
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Hervé Poussineau <hpoussin@reactos.org>
Cc: qemu-ppc@nongnu.org
Cc: qemu-block@nongnu.org
Cc: John Snow <jsnow@redhat.com>
Andreas Färber (8):
parallel: Factor out header for ISAParallelState struct
pc87312: Create isa-parallel in-place and add alias par0-chardev
property
serial: Move ISASerialState to header
pc87312: Create UARTs in-place and add alias properties
fdb: Move FDCtrlISABus to header
pc87312: Create FDC in-place
ide: Move ISAIDEState to header
pc87312: Create IDE in-place
hw/block/fdc.c | 87 -----------------------
hw/char/parallel.c | 30 +-------
hw/char/serial-isa.c | 12 ----
hw/ide/internal.h | 155 ----------------------------------------
hw/ide/isa.c | 13 ----
hw/isa/pc87312.c | 107 ++++++++++++++++------------
hw/ppc/prep.c | 33 +++++++++
include/hw/block/fdc.h | 88 +++++++++++++++++++++++
include/hw/char/parallel.h | 62 ++++++++++++++++
include/hw/char/serial.h | 14 ++++
include/hw/ide.h | 173 +++++++++++++++++++++++++++++++++++++++++++++
include/hw/isa/pc87312.h | 23 +++---
12 files changed, 442 insertions(+), 355 deletions(-)
create mode 100644 include/hw/char/parallel.h
--
2.1.4
next reply other threads:[~2015-03-29 17:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 17:53 Andreas Färber [this message]
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 1/8] parallel: Factor out header for ISAParallelState struct Andreas Färber
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 2/8] pc87312: Create isa-parallel in-place and add alias par0-chardev property Andreas Färber
2015-03-30 14:12 ` Markus Armbruster
2015-03-30 14:36 ` Andreas Färber
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 3/8] serial: Move ISASerialState to header Andreas Färber
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 4/8] pc87312: Create UARTs in-place and add alias properties Andreas Färber
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 5/8] fdb: Move FDCtrlISABus to header Andreas Färber
2015-03-31 1:38 ` John Snow
2015-05-19 13:02 ` Andreas Färber
2015-05-19 15:40 ` John Snow
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 6/8] pc87312: Create FDC in-place Andreas Färber
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 7/8] ide: Move ISAIDEState to header Andreas Färber
2015-03-29 17:53 ` [Qemu-devel] [PATCH RFC for-2.3? 8/8] pc87312: Create IDE in-place Andreas Färber
2015-03-30 14:25 ` [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage Markus Armbruster
2015-03-30 16:12 ` Paolo Bonzini
2015-03-30 16:18 ` Andreas Färber
2015-03-30 18:09 ` Markus Armbruster
2015-03-30 16:42 ` Markus Armbruster
2015-03-30 17:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427651603-9210-1-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=hpoussin@reactos.org \
--cc=jsnow@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).