qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	Mark Cave-Ayland <mark.cave-ayland@ilade.co.uk>
Subject: [Qemu-devel] [PATCH for-2.3 2/6] gus: clean up MemoryRegionPortio
Date: Mon, 30 Mar 2015 13:45:14 +0200	[thread overview]
Message-ID: <1427715918-25768-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1427715918-25768-1-git-send-email-pbonzini@redhat.com>

Remove 16-bit reads/writes, since ioport.c is able to synthesize them.
Remove the two MIDI registers (0x300 and 0x301) from gus_portio_list1,
and add the second MIDI register (0x301) to gus_portio_list2.

Tested with 2nd Reality.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/audio/gus.c | 22 ++--------------------
 1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/hw/audio/gus.c b/hw/audio/gus.c
index 4a43ce7..772010e 100644
--- a/hw/audio/gus.c
+++ b/hw/audio/gus.c
@@ -71,13 +71,6 @@ IO_READ_PROTO (gus_readb)
     return gus_read (&s->emu, nport, 1);
 }
 
-IO_READ_PROTO (gus_readw)
-{
-    GUSState *s = opaque;
-
-    return gus_read (&s->emu, nport, 2);
-}
-
 IO_WRITE_PROTO (gus_writeb)
 {
     GUSState *s = opaque;
@@ -85,13 +78,6 @@ IO_WRITE_PROTO (gus_writeb)
     gus_write (&s->emu, nport, 1, val);
 }
 
-IO_WRITE_PROTO (gus_writew)
-{
-    GUSState *s = opaque;
-
-    gus_write (&s->emu, nport, 2, val);
-}
-
 static int write_audio (GUSState *s, int samples)
 {
     int net = 0;
@@ -236,17 +222,13 @@ static const VMStateDescription vmstate_gus = {
 
 static const MemoryRegionPortio gus_portio_list1[] = {
     {0x000,  1, 1, .write = gus_writeb },
-    {0x000,  1, 2, .write = gus_writew },
     {0x006, 10, 1, .read = gus_readb, .write = gus_writeb },
-    {0x006, 10, 2, .read = gus_readw, .write = gus_writew },
-    {0x100,  8, 1, .read = gus_readb, .write = gus_writeb },
-    {0x100,  8, 2, .read = gus_readw, .write = gus_writew },
+    {0x102,  6, 1, .read = gus_readb, .write = gus_writeb },
     PORTIO_END_OF_LIST (),
 };
 
 static const MemoryRegionPortio gus_portio_list2[] = {
-    {0, 1, 1, .read = gus_readb },
-    {0, 1, 2, .read = gus_readw },
+    {0, 2, 1, .read = gus_readb },
     PORTIO_END_OF_LIST (),
 };
 
-- 
2.3.4

  parent reply	other threads:[~2015-03-30 11:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 11:45 [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw Paolo Bonzini
2015-03-31 11:19   ` Andreas Färber
2015-03-31 11:21     ` Paolo Bonzini
2015-03-30 11:45 ` Paolo Bonzini [this message]
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 3/6] ide: there is only one data port Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 4/6] ioport: remove wrong comment Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 5/6] ioport: loosen assertions on emulation of 16-bit ports Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 6/6] ioport: reserve the whole range of an I/O port in the AddressSpace Paolo Bonzini
2015-03-31 21:47 ` [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes Mark Cave-Ayland
2015-04-01  9:10 ` Peter Maydell
2015-04-01  9:22   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427715918-25768-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mark.cave-ayland@ilade.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).