qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	Mark Cave-Ayland <mark.cave-ayland@ilade.co.uk>,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.3 3/6] ide: there is only one data port
Date: Mon, 30 Mar 2015 13:45:15 +0200	[thread overview]
Message-ID: <1427715918-25768-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1427715918-25768-1-git-send-email-pbonzini@redhat.com>

IDE PIO data must be written, for example, at 0x1f0.  You cannot
do word or dword writes to 0x1f1..0x1f3 to access the data register.
Adjust the ide_portio_list accordingly.

Cc: John Snow <jsnow@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/ide/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index a895fd8..fcb9080 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2436,8 +2436,8 @@ void ide_init2(IDEBus *bus, qemu_irq irq)
 
 static const MemoryRegionPortio ide_portio_list[] = {
     { 0, 8, 1, .read = ide_ioport_read, .write = ide_ioport_write },
-    { 0, 2, 2, .read = ide_data_readw, .write = ide_data_writew },
-    { 0, 4, 4, .read = ide_data_readl, .write = ide_data_writel },
+    { 0, 1, 2, .read = ide_data_readw, .write = ide_data_writew },
+    { 0, 1, 4, .read = ide_data_readl, .write = ide_data_writel },
     PORTIO_END_OF_LIST(),
 };
 
-- 
2.3.4

  parent reply	other threads:[~2015-03-30 11:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 11:45 [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw Paolo Bonzini
2015-03-31 11:19   ` Andreas Färber
2015-03-31 11:21     ` Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 2/6] gus: clean up MemoryRegionPortio Paolo Bonzini
2015-03-30 11:45 ` Paolo Bonzini [this message]
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 4/6] ioport: remove wrong comment Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 5/6] ioport: loosen assertions on emulation of 16-bit ports Paolo Bonzini
2015-03-30 11:45 ` [Qemu-devel] [PATCH for-2.3 6/6] ioport: reserve the whole range of an I/O port in the AddressSpace Paolo Bonzini
2015-03-31 21:47 ` [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes Mark Cave-Ayland
2015-04-01  9:10 ` Peter Maydell
2015-04-01  9:22   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427715918-25768-4-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mark.cave-ayland@ilade.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).