From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcaC2-0007Xd-Er for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:57:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcaBv-0005ES-Li for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:57:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcaBv-0005EE-F4 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:57:23 -0400 From: Stefan Hajnoczi Date: Mon, 30 Mar 2015 14:57:15 +0100 Message-Id: <1427723836-302-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1427723836-302-1-git-send-email-stefanha@redhat.com> References: <1427723836-302-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] virtfs-proxy-helper: add missing long option terminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Aneesh Kumar K.V" , Stefan Hajnoczi The getopt_long(3) long options array must have a zeroed terminator. This patch solves a segmentation fault when an unknown command-line option is encountered: $ fsdev/virtfs-proxy-helper --help Segmentation fault (core dumped) Signed-off-by: Stefan Hajnoczi --- fsdev/virtfs-proxy-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index a698e2d..91e8b9b 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -49,6 +49,7 @@ static struct option helper_opts[] = { {"socket", required_argument, NULL, 's'}, {"uid", required_argument, NULL, 'u'}, {"gid", required_argument, NULL, 'g'}, + {}, }; static bool is_daemon; -- 2.1.0