From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yd0jo-0006eK-Jj for qemu-devel@nongnu.org; Tue, 31 Mar 2015 14:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yd0jj-0001lP-7P for qemu-devel@nongnu.org; Tue, 31 Mar 2015 14:18:08 -0400 Message-ID: <1427825872.5567.177.camel@redhat.com> From: Alex Williamson Date: Tue, 31 Mar 2015 12:17:52 -0600 In-Reply-To: <1427352132-1762-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1427352132-1762-1-git-send-email-nikunj@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: aik@ozlabs.ru, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote: > From PCIDevice there is no way to know if the device has a backing > vfio device. > > sPAPR guests inherits the "ibm,loc-code" from the pci pass through > device in hypervisor. This helps in identifying the device if there is > any failures using this "ibm,loc-code" for RAS capabilities. > > CC: Alex Williamson > CC: Alexander Graf > Signed-off-by: Nikunj A Dadhania > --- > hw/vfio/pci.c | 2 ++ > include/hw/pci/pci.h | 2 ++ > 2 files changed, 4 insertions(+) I agree with the other comments on this series, the vfio information can be found using existing object and property functions. Nak to the vfio related changes. Also, please us cover letters for multi-patch series. Thanks, Alex