From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdFu9-0006bf-Sr for qemu-devel@nongnu.org; Wed, 01 Apr 2015 06:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdFu4-0000hm-Kw for qemu-devel@nongnu.org; Wed, 01 Apr 2015 06:29:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdFu4-0000hQ-Ds for qemu-devel@nongnu.org; Wed, 01 Apr 2015 06:29:44 -0400 From: Paolo Bonzini Date: Wed, 1 Apr 2015 12:29:34 +0200 Message-Id: <1427884177-4928-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1427884177-4928-1-git-send-email-pbonzini@redhat.com> References: <1427884177-4928-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 2/5] hostmem: Prevent removing an in-use memory backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Lin Ma From: Lin Ma showing a memory device whose memdev is removed leads an assert: (qemu) object_add memory-backend-ram,id=ram0,size=128M (qemu) device_add pc-dimm,id=d0,memdev=ram0 (qemu) object_del ram0 (qemu) info memory-devices ** ERROR:qom/object.c:1274:object_get_canonical_path_component:\ assertion failed: (obj->parent != NULL) Aborted The patch prevents removing an in-use mem backend and error out. Signed-off-by: Lin Ma Message-Id: <1427704589-7688-3-git-send-email-lma@suse.com> Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- backends/hostmem.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/backends/hostmem.c b/backends/hostmem.c index 99e8f99..b7b6cf8 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -335,12 +335,26 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) } } +static bool +host_memory_backend_can_be_deleted(UserCreatable *uc, Error **errp) +{ + MemoryRegion *mr; + + mr = host_memory_backend_get_memory(MEMORY_BACKEND(uc), errp); + if (memory_region_is_mapped(mr)) { + return false; + } else { + return true; + } +} + static void host_memory_backend_class_init(ObjectClass *oc, void *data) { UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); ucc->complete = host_memory_backend_memory_complete; + ucc->can_be_deleted = host_memory_backend_can_be_deleted; } static const TypeInfo host_memory_backend_info = { -- 2.3.4