qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 0/5] hw: Contain drive, serial, parallel, net misuse
Date: Wed,  1 Apr 2015 17:03:01 +0200	[thread overview]
Message-ID: <1427900586-5358-1-git-send-email-armbru@redhat.com> (raw)

Drives defined with if!=none, character devices defined with -serial
and -parallel, network devices defined with -net nic are all for board
initialization to wire up.  Board code calls drive_get() or similar to
find them, and creates devices with their qdev properties set
accordingly.

Except a few devices go on fishing expeditions on their own instead of
exposing a drive property for board code to set.

We can't fix this in time for the release, so do the next best thing:
contain the mistakes as far as possible so they don't become ABI:

* Mark them all with suitable FIXME comments [PATCH 1-3].

* sdhci-pci is new, set cannot_instantiate_with_device_add_yet to make
  it unavailable with -device [PATCH 4].

* A few more aren't currently available with -device, set
  cannot_instantiate_with_device_add_yet to ensure they stay
  unavailable [PATCH 5].

* Left alone: m25p80-generic and its derivatives[*], ssi-sd, pc87312.
  I suspect these can't be used sanely with -device / device_add, and
  cannot_instantiate_with_device_add_yet for them would be just fine,
  but I feel we're too close to the release to argue this now.

The following changes since commit b8a86c4ac4d04c106ba38fbd707041cba334a155:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-04-01 11:31:31 +0100)

are available in the git repository at:


  git://repo.or.cz/qemu/armbru.git tags/pull-hw-2015-04-01

for you to fetch changes up to 7157bc9cf431e1debd0afb8e9cb6ab597ef93828:

  sysbus: Make devices picking up backends unavailable with -device (2015-04-01 16:08:53 +0200)

----------------------------------------------------------------
hw: Contain drive, serial, parallel, net misuse

----------------------------------------------------------------
Markus Armbruster (5):
  hw: Mark devices picking up block backends actively FIXME
  hw: Mark devices picking up char backends actively FIXME
  hw: Mark device misusing nd_table[] FIXME
  sdhci: Make device "sdhci-pci" unavailable with -device
  sysbus: Make devices picking up backends unavailable with -device

 hw/arm/allwinner-a10.c    | 2 ++
 hw/arm/spitz.c            | 3 +++
 hw/block/m25p80.c         | 1 +
 hw/char/cadence_uart.c    | 3 +++
 hw/char/digic-uart.c      | 3 +++
 hw/char/etraxfs_ser.c     | 3 +++
 hw/char/lm32_juart.c      | 3 +++
 hw/char/lm32_uart.c       | 3 +++
 hw/char/milkymist-uart.c  | 3 +++
 hw/char/pl011.c           | 3 +++
 hw/char/stm32f2xx_usart.c | 3 +++
 hw/char/xilinx_uartlite.c | 3 +++
 hw/isa/pc87312.c          | 4 ++++
 hw/sd/milkymist-memcard.c | 3 +++
 hw/sd/pl181.c             | 3 +++
 hw/sd/sdhci.c             | 5 +++++
 hw/sd/ssi-sd.c            | 1 +
 17 files changed, 49 insertions(+)

-- 
1.9.3

             reply	other threads:[~2015-04-01 15:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 15:03 Markus Armbruster [this message]
2015-04-01 15:03 ` [Qemu-devel] [PULL 1/5] hw: Mark devices picking up block backends actively FIXME Markus Armbruster
2015-04-01 15:03 ` [Qemu-devel] [PULL 2/5] hw: Mark devices picking up char " Markus Armbruster
2015-04-01 15:03 ` [Qemu-devel] [PULL 3/5] hw: Mark device misusing nd_table[] FIXME Markus Armbruster
2015-04-01 15:03 ` [Qemu-devel] [PULL 4/5] sdhci: Make device "sdhci-pci" unavailable with -device Markus Armbruster
2015-04-01 15:03 ` [Qemu-devel] [PULL 5/5] sysbus: Make devices picking up backends " Markus Armbruster
2015-04-01 16:18 ` [Qemu-devel] [PULL 0/5] hw: Contain drive, serial, parallel, net misuse Peter Maydell
2015-04-02 13:25   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427900586-5358-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).