From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdiwH-0001OA-Ou for qemu-devel@nongnu.org; Thu, 02 Apr 2015 13:29:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdiwG-0007of-VG for qemu-devel@nongnu.org; Thu, 02 Apr 2015 13:29:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdiwG-0007oQ-OQ for qemu-devel@nongnu.org; Thu, 02 Apr 2015 13:29:56 -0400 From: Markus Armbruster Date: Thu, 2 Apr 2015 19:28:55 +0200 Message-Id: <1427995743-7865-12-git-send-email-armbru@redhat.com> In-Reply-To: <1427995743-7865-1-git-send-email-armbru@redhat.com> References: <1427995743-7865-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH RFC 11/19] qapi: Fix generators to report command line errors decently List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, akong@redhat.com, mdroth@linux.vnet.ibm.com Report to stderr, prefix with the program name. Also reject extra arguments. Signed-off-by: Markus Armbruster --- scripts/qapi.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 1d8a3e5..c952c26 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -907,7 +907,7 @@ def parse_command_line(extra_options = "", extra_long_options = []): "input-file=", "output-dir="] + extra_long_options) except getopt.GetoptError, err: - print str(err) + print >>sys.stderr, "%s: %s" % (sys.argv[0], str(err)) sys.exit(1) output_dir = "" @@ -935,4 +935,8 @@ def parse_command_line(extra_options = "", extra_long_options = []): do_c = True do_h = True + if len(args) != 0: + print >>sys.stderr, "%s: too many arguments"% sys.argv[0] + sys.exit(1) + return (input_file, output_dir, do_c, do_h, prefix, extra_opts) -- 1.9.3