qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, berto@igalia.com, akong@redhat.com,
	mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH RFC 15/19] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue()
Date: Thu,  2 Apr 2015 19:28:59 +0200	[thread overview]
Message-ID: <1427995743-7865-16-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1427995743-7865-1-git-send-email-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi-commands.py | 58 ++++++++++++++++++++----------------------------
 1 file changed, 24 insertions(+), 34 deletions(-)

diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
index 10fa570..bf41a78 100644
--- a/scripts/qapi-commands.py
+++ b/scripts/qapi-commands.py
@@ -319,36 +319,6 @@ qapi_init(qmp_init_marshal);
                 registry=registry.rstrip())
     return ret
 
-def gen_command_decl_prologue(prefix=""):
-    ret = mcgen('''
-#include "%(prefix)sqapi-types.h"
-#include "qapi/qmp/qdict.h"
-#include "qapi/error.h"
-
-''',
-                 prefix=prefix)
-    return ret
-
-def gen_command_def_prologue(prefix="", proxy=False):
-    ret = mcgen('''
-#include "qemu-common.h"
-#include "qemu/module.h"
-#include "qapi/qmp/qerror.h"
-#include "qapi/qmp/types.h"
-#include "qapi/qmp/dispatch.h"
-#include "qapi/visitor.h"
-#include "qapi/qmp-output-visitor.h"
-#include "qapi/qmp-input-visitor.h"
-#include "qapi/dealloc-visitor.h"
-#include "%(prefix)sqapi-types.h"
-#include "%(prefix)sqapi-visit.h"
-
-''',
-                prefix=prefix)
-    if not proxy:
-        ret += '#include "%sqmp-commands.h"' % prefix
-    return ret + "\n\n"
-
 middle_mode = False
 
 (input_file, output_dir, do_c, do_h, prefix, opts) = \
@@ -395,10 +365,30 @@ h_comment = '''
                             'qmp-marshal.c', 'qmp-commands.h',
                             c_comment, h_comment)
 
-ret = gen_command_decl_prologue(prefix=prefix)
-fdecl.write(ret)
-ret = gen_command_def_prologue(prefix=prefix)
-fdef.write(ret)
+fdef.write(mcgen('''
+#include "qemu-common.h"
+#include "qemu/module.h"
+#include "qapi/qmp/qerror.h"
+#include "qapi/qmp/types.h"
+#include "qapi/qmp/dispatch.h"
+#include "qapi/visitor.h"
+#include "qapi/qmp-output-visitor.h"
+#include "qapi/qmp-input-visitor.h"
+#include "qapi/dealloc-visitor.h"
+#include "%(prefix)sqapi-types.h"
+#include "%(prefix)sqapi-visit.h"
+#include "%(prefix)sqmp-commands.h"
+
+''',
+                prefix=prefix))
+
+fdecl.write(mcgen('''
+#include "%(prefix)sqapi-types.h"
+#include "qapi/qmp/qdict.h"
+#include "qapi/error.h"
+
+''',
+                 prefix=prefix))
 
 for cmd in commands:
     arglist = []
-- 
1.9.3

  parent reply	other threads:[~2015-04-02 17:29 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 17:28 [Qemu-devel] [PATCH RFC 00/19] qapi: QMP introspection Markus Armbruster
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 01/19] tests: Add missing dependencies on $(qapi-py) Markus Armbruster
2015-04-02 19:40   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 02/19] qapi: Fix C identifiers generated for names containing '.' Markus Armbruster
2015-04-02 21:48   ` Eric Blake
2015-04-29  7:08     ` Markus Armbruster
2015-04-06 23:25   ` Eric Blake
2015-04-11 18:36     ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 03/19] qapi: Rename _generate_enum_string() to camel_to_upper() Markus Armbruster
2015-04-10 22:17   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 04/19] qapi: Rename generate_enum_full_value() to c_enum_const() Markus Armbruster
2015-04-11 18:37   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 05/19] qapi: Simplify c_enum_const() Markus Armbruster
2015-04-13 14:40   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 06/19] qapi: Use c_enum_const() in generate_alternate_qtypes() Markus Armbruster
2015-04-13 19:03   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 07/19] qapi: Move camel_to_upper(), c_enum_const() to closely related code Markus Armbruster
2015-04-13 19:06   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 08/19] qapi: qapi-event.py option -b does nothing, drop it Markus Armbruster
2015-04-13 19:07   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, " Markus Armbruster
2015-04-13 19:12   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 10/19] qapi: Factor parse_command_line() out of the generators Markus Armbruster
2015-04-13 19:14   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 11/19] qapi: Fix generators to report command line errors decently Markus Armbruster
2015-04-13 19:15   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 12/19] qapi: Turn generators' mandatory option -i into an argument Markus Armbruster
2015-04-13 19:17   ` Eric Blake
2015-04-29  7:11     ` Markus Armbruster
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 13/19] qapi: Factor open_output(), close_output() out of generators Markus Armbruster
2015-04-13 19:44   ` Eric Blake
2015-04-02 17:28 ` [Qemu-devel] [PATCH RFC 14/19] qapi: Drop pointless flush() before close() Markus Armbruster
2015-04-13 20:29   ` Eric Blake
2015-04-02 17:28 ` Markus Armbruster [this message]
2015-04-13 20:34   ` [Qemu-devel] [PATCH RFC 15/19] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue() Eric Blake
2015-04-02 17:29 ` [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code Markus Armbruster
2015-04-14  3:32   ` Eric Blake
2015-04-02 17:29 ` [Qemu-devel] [PATCH RFC 17/19] qobject: Add a special null QObject Markus Armbruster
2015-04-14  3:44   ` Eric Blake
2015-04-29  7:15     ` Markus Armbruster
2015-04-02 17:29 ` [Qemu-devel] [PATCH RFC 18/19] json-parser: Fix to recognize null Markus Armbruster
2015-04-14  3:45   ` Eric Blake
2015-04-02 17:29 ` [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection Markus Armbruster
2015-04-10 23:06   ` Eric Blake
2015-04-15  9:16     ` Alberto Garcia
2015-04-15 12:56       ` Eric Blake
2015-04-23 12:55         ` Kevin Wolf
2015-04-23 19:29           ` Eric Blake
2015-04-29  8:46     ` Markus Armbruster
2015-04-23 13:13   ` Kevin Wolf
2015-04-29  9:02     ` Markus Armbruster
2015-05-01 21:41   ` Eric Blake
2015-05-04  7:17     ` Markus Armbruster
2015-04-02 19:29 ` [Qemu-devel] [PATCH RFC 00/19] qapi: QMP introspection Eric Blake
2015-04-06 23:20 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427995743-7865-16-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=akong@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).