From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye2Ex-0007vn-76 for qemu-devel@nongnu.org; Fri, 03 Apr 2015 10:06:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ye2Er-0001ox-G2 for qemu-devel@nongnu.org; Fri, 03 Apr 2015 10:06:31 -0400 From: Fam Zheng Date: Fri, 3 Apr 2015 22:05:19 +0800 Message-Id: <1428069921-2957-3-git-send-email-famz@redhat.com> In-Reply-To: <1428069921-2957-1-git-send-email-famz@redhat.com> References: <1428069921-2957-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/4] block: Pause block jobs in bdrv_drain_all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , berto@igalia.com, qemu-block@nongnu.org, Jeff Cody , Stefan Hajnoczi , pbonzini@redhat.com This is necessary to suppress more IO requests from being generated from block job coroutines. Signed-off-by: Fam Zheng --- block.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/block.c b/block.c index f2f8ae7..00cd91e 100644 --- a/block.c +++ b/block.c @@ -2033,6 +2033,16 @@ void bdrv_drain_all(void) bool busy = true; BlockDriverState *bs; + QTAILQ_FOREACH(bs, &bdrv_states, device_list) { + AioContext *aio_context = bdrv_get_aio_context(bs); + + aio_context_acquire(aio_context); + if (bs->job) { + block_job_pause(bs->job); + } + aio_context_release(aio_context); + } + while (busy) { busy = false; @@ -2044,6 +2054,16 @@ void bdrv_drain_all(void) aio_context_release(aio_context); } } + + QTAILQ_FOREACH(bs, &bdrv_states, device_list) { + AioContext *aio_context = bdrv_get_aio_context(bs); + + aio_context_acquire(aio_context); + if (bs->job) { + block_job_resume(bs->job); + } + aio_context_release(aio_context); + } } /* make a BlockDriverState anonymous by removing from bdrv_state and -- 2.1.0