From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwBb-0001PT-GY for qemu-devel@nongnu.org; Wed, 08 Apr 2015 16:02:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfwBa-0005yA-LR for qemu-devel@nongnu.org; Wed, 08 Apr 2015 16:02:55 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:33619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwBa-0005y4-Ep for qemu-devel@nongnu.org; Wed, 08 Apr 2015 16:02:54 -0400 From: Peter Maydell Date: Wed, 8 Apr 2015 21:02:49 +0100 Message-Id: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Roth , patches@linaro.org The second argument of g_base64_decode() is a 'gsize *', not a 'size_t *'. Some compilation environments (like building 32-bit PPC binaries on a PPC64 system) will complain about the mismatch: CC qga/commands-posix.o qga/commands-posix.c: In function 'qmp_guest_set_user_password': qga/commands-posix.c:1908:5: error: passing argument 2 of 'g_base64_decode' from incompatible pointer type [-Werror] In file included from /usr/include/glib-2.0/glib.h:37:0, from qga/commands-posix.c:14: /usr/include/glib-2.0/glib/gbase64.h:49:9: note: expected ‘gsize *’ but argument is of type ‘size_t *’ (We previously fixed errors of this type in commit 3d1bba20.) Signed-off-by: Peter Maydell --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index ba8de62..9fde348 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1901,7 +1901,7 @@ void qmp_guest_set_user_password(const char *username, int status; int datafd[2] = { -1, -1 }; char *rawpasswddata = NULL; - size_t rawpasswdlen; + gsize rawpasswdlen; char *chpasswddata = NULL; size_t chpasswdlen; -- 1.9.1