From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: peter.maydell@linaro.org, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] configure: improve multiarch support for pkgconfig
Date: Fri, 10 Apr 2015 15:59:10 +0200 [thread overview]
Message-ID: <1428674350.29519.3.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20150410122123.GN23555@stefanha-thinkpad.redhat.com>
Hi,
> 32-bit compilation on 64-bit hosts is broken because pkgconfig isn't
> multi-arch aware and selects the 64-bit glibconfig.h header file. That
> file assumes the LP64 data model so guint64 is defined as unsigned long.
> This does not work for 32-bit builds where sizeof(unsigned long) == 4
> bytes.
... there are more effects, like stuff being enabled because 64bit devel
lib is installed even when the 32bit devel lib isn't.
IMO it is fine to expect users set PKG_CONFIG_LIBDIR accordingly in that
case. It would be very nice though to record this variable (in
config.status maybe?) so it doesn't get lost in case make figures it
should re-run configure because it was changed.
cheers,
Gerd
next prev parent reply other threads:[~2015-04-10 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 21:36 [Qemu-devel] [PATCH] configure: improve multiarch support for pkgconfig John Snow
2015-04-10 12:06 ` Paolo Bonzini
2015-04-10 12:21 ` Stefan Hajnoczi
2015-04-10 12:55 ` Peter Maydell
2015-04-10 14:06 ` John Snow
2015-04-10 13:59 ` Gerd Hoffmann [this message]
2015-04-10 14:15 ` John Snow
2015-04-10 14:24 ` Gerd Hoffmann
2015-04-10 12:24 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428674350.29519.3.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).