From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YheJe-0000Xr-Cx for qemu-devel@nongnu.org; Mon, 13 Apr 2015 09:22:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YheJd-0000hw-Mt for qemu-devel@nongnu.org; Mon, 13 Apr 2015 09:22:18 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:33795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YheJd-0000fw-9T for qemu-devel@nongnu.org; Mon, 13 Apr 2015 09:22:17 -0400 From: Peter Maydell Date: Mon, 13 Apr 2015 14:22:04 +0100 Message-Id: <1428931324-4973-15-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1428931324-4973-1-git-send-email-peter.maydell@linaro.org> References: <1428931324-4973-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH v2 14/14] target-arm: Check watchpoints against CPU security state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Crosthwaite , patches@linaro.org, "Edgar E. Iglesias" , Greg Bellows , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Fix a TODO in bp_wp_matches() now that we have a function for testing whether the CPU is currently in Secure mode or not. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- target-arm/op_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 4a8c4e0..3df9c57 100644 --- a/target-arm/op_helper.c +++ b/target-arm/op_helper.c @@ -600,8 +600,10 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_wp) CPUARMState *env = &cpu->env; uint64_t cr; int pac, hmc, ssc, wt, lbn; - /* TODO: check against CPU security state when we implement TrustZone */ - bool is_secure = false; + /* Note that for watchpoints the check is against the CPU security + * state, not the S/NS attribute on the offending data access. + */ + bool is_secure = arm_is_secure(env); int access_el = arm_current_el(env); if (is_wp) { -- 1.9.1