From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Peter Lieven <pl@kamp.de>,
ronniesahlberg@gmail.com, qemu-block@nongnu.org,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH for-2.4 01/10] block/iscsi: do not forget to logout from target
Date: Thu, 16 Apr 2015 14:18:41 +0200 [thread overview]
Message-ID: <1429186730-3866-2-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1429186730-3866-1-git-send-email-pl@kamp.de>
We actually were always impolitely dropping the connection and
not cleanly logging out.
CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/iscsi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index ba33290..be8af46 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1501,6 +1501,9 @@ out:
if (ret) {
if (iscsi != NULL) {
+ if (iscsi_is_logged_in(iscsi)) {
+ iscsi_logout_sync(iscsi);
+ }
iscsi_destroy_context(iscsi);
}
memset(iscsilun, 0, sizeof(IscsiLun));
@@ -1514,6 +1517,9 @@ static void iscsi_close(BlockDriverState *bs)
struct iscsi_context *iscsi = iscsilun->iscsi;
iscsi_detach_aio_context(bs);
+ if (iscsi_is_logged_in(iscsi)) {
+ iscsi_logout_sync(iscsi);
+ }
iscsi_destroy_context(iscsi);
g_free(iscsilun->zeroblock);
g_free(iscsilun->allocationmap);
--
1.9.1
next prev parent reply other threads:[~2015-04-16 12:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 12:18 [Qemu-devel] [PATCH for-2.4 00/10] various improvements for the iSCSI driver Peter Lieven
2015-04-16 12:18 ` Peter Lieven [this message]
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 02/10] block/iscsi: change all iscsilun properties from uint8_t to bool Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 03/10] block/iscsi: rename iscsi_write_protected and let it return void Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 04/10] block/iscsi: store DPOFUA bit from the modesense command Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set Peter Lieven
2015-04-16 12:42 ` Paolo Bonzini
2015-04-16 13:02 ` Peter Lieven
2015-04-16 13:17 ` Paolo Bonzini
2015-04-17 7:14 ` Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 06/10] block/iscsi: increase retry count Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0 Peter Lieven
2015-04-16 12:33 ` Paolo Bonzini
2015-04-16 12:58 ` Peter Lieven
2015-04-16 13:20 ` Paolo Bonzini
2015-04-17 7:16 ` Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 08/10] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 09/10] block/iscsi: bump year in copyright notice Peter Lieven
2015-04-16 12:18 ` [Qemu-devel] [PATCH for-2.4 10/10] block/iscsi: use the allocationmap also if cache.direct=on Peter Lieven
2015-04-16 12:52 ` [Qemu-devel] [PATCH for-2.4 00/10] various improvements for the iSCSI driver Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429186730-3866-2-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).