From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkxPQ-0002tG-S2 for qemu-devel@nongnu.org; Wed, 22 Apr 2015 12:22:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkxPM-0000YE-RQ for qemu-devel@nongnu.org; Wed, 22 Apr 2015 12:21:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkxPM-0000Y5-Jx for qemu-devel@nongnu.org; Wed, 22 Apr 2015 12:21:52 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3MGLp6N020169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 22 Apr 2015 12:21:51 -0400 From: John Snow Date: Wed, 22 Apr 2015 12:21:45 -0400 Message-Id: <1429719709-880-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/4] scripts: qmp-shell: add transaction support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: John Snow , lcapitulino@redhat.com, kchamart@redhat.com The qmp-shell is a little rudimentary, but it can be hacked to give us some transactional support without too much difficulty. (1) Prep. (2) Add support for serializing json arrays (3) Allow users to use 'single quotes' instead of "double quotes" (4) Add a special transaction( ... ) syntax that lets users build up transactional commands using the existing qmp shell syntax to define each action. (5) Add a verbose flag to display generated QMP commands. The parsing is not as robust as one would like, but this suffices without adding a proper parser. Design considerations: (1) Try not to disrupt the existing design of the qmp-shell. The existing API is not disturbed. (2) Pick a "magic token" such that it could not be confused for legitimate QMP/JSON syntax. Parentheses are used for this purpose. === v2: === - Squash patches 2 & 3: - Remove wholesale replacement of single quotes, in favor of try blocks that attempt to parse as pure JSON, then as Python. - Factored out the value parser block to accomplish the above. - Allow both true/True and false/False for values. - Fix typo in patch 3 cover letter. (was patch 4.) John Snow (4): scripts: qmp-shell: refactor helpers scripts: qmp-shell: Expand support for QMP expressions scripts: qmp-shell: add transaction subshell scripts: qmp-shell: Add verbose flag scripts/qmp/qmp-shell | 125 ++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 95 insertions(+), 30 deletions(-) -- 2.1.0