From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlIDf-0000Ds-1q for qemu-devel@nongnu.org; Thu, 23 Apr 2015 10:35:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlIDb-0007S1-Qv for qemu-devel@nongnu.org; Thu, 23 Apr 2015 10:35:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlIDb-0007Rt-M0 for qemu-devel@nongnu.org; Thu, 23 Apr 2015 10:35:07 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 4865091C04 for ; Thu, 23 Apr 2015 14:35:07 +0000 (UTC) From: John Snow Date: Thu, 23 Apr 2015 10:35:01 -0400 Message-Id: <1429799701-27089-5-git-send-email-jsnow@redhat.com> In-Reply-To: <1429799701-27089-1-git-send-email-jsnow@redhat.com> References: <1429799701-27089-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v3 4/4] scripts: qmp-shell: Add verbose flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: John Snow , lcapitulino@redhat.com, kchamart@redhat.com Add a verbose flag that shows the QMP command that was constructed, to allow for later copy/pasting, reference, debugging, etc. Signed-off-by: John Snow Reviewed-by: Eric Blake --- scripts/qmp/qmp-shell | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index c9e4439..17babcd 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -177,6 +177,12 @@ class QMPShell(qmp.QEMUMonitorProtocol): self.__cli_expr(cmdargs[1:], qmpcmd['arguments']) return qmpcmd + def _print(self, qmp): + if self._pp is not None: + self._pp.pprint(qmp) + else: + print qmp + def _execute_cmd(self, cmdline): try: qmpcmd = self.__build_cmd(cmdline) @@ -188,15 +194,13 @@ class QMPShell(qmp.QEMUMonitorProtocol): # For transaction mode, we may have just cached the action: if qmpcmd is None: return True + if self._verbose: + self._print(qmpcmd) resp = self.cmd_obj(qmpcmd) if resp is None: print 'Disconnected' return False - - if self._pp is not None: - self._pp.pprint(resp) - else: - print resp + self._print(resp) return True def connect(self): @@ -232,6 +236,9 @@ class QMPShell(qmp.QEMUMonitorProtocol): else: return self._execute_cmd(cmdline) + def set_verbosity(self, verbose): + self._verbose = verbose + class HMPShell(QMPShell): def __init__(self, address): QMPShell.__init__(self, address) @@ -317,6 +324,7 @@ def main(): qemu = None hmp = False pp = None + verbose = False try: for arg in sys.argv[1:]: @@ -328,6 +336,8 @@ def main(): if pp is not None: fail_cmdline(arg) pp = pprint.PrettyPrinter(indent=4) + elif arg == "-v": + verbose = True else: if qemu is not None: fail_cmdline(arg) @@ -352,6 +362,7 @@ def main(): die('Could not connect to %s' % addr) qemu.show_banner() + qemu.set_verbosity(verbose) while qemu.read_exec_command(qemu.get_prompt()): pass qemu.close() -- 2.1.0