From: Kashyap Chamarthy <kchamart@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com,
Kashyap Chamarthy <kchamart@redhat.com>,
lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v2] qmp-commands.hx: Update the supported 'transaction' operations
Date: Fri, 24 Apr 2015 10:32:47 +0200 [thread overview]
Message-ID: <1429864368-15249-1-git-send-email-kchamart@redhat.com> (raw)
Although the canonical source of reference for QMP commands is
qapi-schema.json, for consistency's sake, update qmp-commands.hx to
state the list of supported transactionable operations, namely:
drive-backup
blockdev-backup
blockdev-snapshot-internal-sync
abort
block-dirty-bitmap-add
block-dirty-bitmap-clear
NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-clear' commands
will be available once the in-review "transactionless incremental
backup" patch series[1] is merged upstream.
[1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
>From v1 -> v2:
- Update the "NB" part of the commit message by removing the duplicate
command entry and add the missing one ('block-dirty-bitmap-clear')
- Fix grammer per Eric Blake's review: s/refer/refer to the
---
qmp-commands.hx | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 3a42ad0bffeb23778f877410f6e2038943da46c0..b7fe31ca37afe0f4ae8f4b6f7be5d379b361b1b8 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1200,11 +1200,14 @@ SQMP
transaction
-----------
-Atomically operate on one or more block devices. The only supported operations
-for now are drive-backup, internal and external snapshotting. A list of
-dictionaries is accepted, that contains the actions to be performed.
-If there is any failure performing any of the operations, all operations
-for the group are abandoned.
+Atomically operate on one or more block devices. Operations that are
+currently supported: drive-backup, blockdev-backup,
+blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort,
+block-dirty-bitmap-add, block-dirty-bitmap-clear (refer to the
+qemu/qapi-schema.json file for minimum required QEMU versions for these
+operations). A list of dictionaries is accepted, that contains the
+actions to be performed. If there is any failure performing any of the
+operations, all operations for the group are abandoned.
For external snapshots, the dictionary contains the device, the file to use for
the new snapshot, and the format. The default format, if not specified, is
--
2.1.0
next reply other threads:[~2015-04-24 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 8:32 Kashyap Chamarthy [this message]
2015-04-24 15:52 ` [Qemu-devel] [PATCH v2] qmp-commands.hx: Update the supported 'transaction' operations John Snow
2015-04-24 16:20 ` Kashyap Chamarthy
2015-04-24 16:21 ` John Snow
2015-04-24 20:51 ` Eric Blake
2015-04-25 17:18 ` Kashyap Chamarthy
2015-04-27 9:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429864368-15249-1-git-send-email-kchamart@redhat.com \
--to=kchamart@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).