From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlZ2k-0007Yu-PD for qemu-devel@nongnu.org; Fri, 24 Apr 2015 04:33:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlZ2h-0002ir-60 for qemu-devel@nongnu.org; Fri, 24 Apr 2015 04:33:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlZ2g-0002ij-UG for qemu-devel@nongnu.org; Fri, 24 Apr 2015 04:32:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3O8WwNI003699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Apr 2015 04:32:58 -0400 From: Kashyap Chamarthy Date: Fri, 24 Apr 2015 10:32:47 +0200 Message-Id: <1429864368-15249-1-git-send-email-kchamart@redhat.com> Subject: [Qemu-devel] [PATCH v2] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, Kashyap Chamarthy , lcapitulino@redhat.com Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync abort block-dirty-bitmap-add block-dirty-bitmap-clear NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-clear' commands will be available once the in-review "transactionless incremental backup" patch series[1] is merged upstream. [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html Signed-off-by: Kashyap Chamarthy Reviewed-by: Eric Blake --- >>From v1 -> v2: - Update the "NB" part of the commit message by removing the duplicate command entry and add the missing one ('block-dirty-bitmap-clear') - Fix grammer per Eric Blake's review: s/refer/refer to the --- qmp-commands.hx | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 3a42ad0bffeb23778f877410f6e2038943da46c0..b7fe31ca37afe0f4ae8f4b6f7be5d379b361b1b8 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1200,11 +1200,14 @@ SQMP transaction ----------- -Atomically operate on one or more block devices. The only supported operations -for now are drive-backup, internal and external snapshotting. A list of -dictionaries is accepted, that contains the actions to be performed. -If there is any failure performing any of the operations, all operations -for the group are abandoned. +Atomically operate on one or more block devices. Operations that are +currently supported: drive-backup, blockdev-backup, +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer to the +qemu/qapi-schema.json file for minimum required QEMU versions for these +operations). A list of dictionaries is accepted, that contains the +actions to be performed. If there is any failure performing any of the +operations, all operations for the group are abandoned. For external snapshots, the dictionary contains the device, the file to use for the new snapshot, and the format. The default format, if not specified, is -- 2.1.0