From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Andreas Färber" <afaerber@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH] target-i386: Use X86CPU on cpu_clear_apic_feature()
Date: Fri, 24 Apr 2015 16:12:06 -0300 [thread overview]
Message-ID: <1429902726-31669-1-git-send-email-ehabkost@redhat.com> (raw)
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/intc/apic.c | 2 +-
target-i386/cpu.c | 4 ++--
target-i386/cpu.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index 2f19c19..175e601 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -298,7 +298,7 @@ static void apic_set_base(APICCommonState *s, uint64_t val)
/* if disabled, cannot be enabled again */
if (!(val & MSR_IA32_APICBASE_ENABLE)) {
s->apicbase &= ~MSR_IA32_APICBASE_ENABLE;
- cpu_clear_apic_feature(&s->cpu->env);
+ cpu_clear_apic_feature(s->cpu);
s->spurious_vec &= ~APIC_SV_ENABLE;
}
}
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index cee7054..07465ac 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2202,9 +2202,9 @@ static void x86_register_cpudef_type(X86CPUDefinition *def)
#if !defined(CONFIG_USER_ONLY)
-void cpu_clear_apic_feature(CPUX86State *env)
+void cpu_clear_apic_feature(X86CPU *cpu)
{
- env->features[FEAT_1_EDX] &= ~CPUID_APIC;
+ cpu->env.features[FEAT_1_EDX] &= ~CPUID_APIC;
}
#endif /* !CONFIG_USER_ONLY */
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 19c71ac..1d9f1d7 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -1096,7 +1096,7 @@ int cpu_x86_signal_handler(int host_signum, void *pinfo,
void cpu_x86_cpuid(X86CPU *cpu, uint32_t index, uint32_t count,
uint32_t *eax, uint32_t *ebx,
uint32_t *ecx, uint32_t *edx);
-void cpu_clear_apic_feature(CPUX86State *env);
+void cpu_clear_apic_feature(X86CPU *cpu);
void host_cpuid(uint32_t function, uint32_t count,
uint32_t *eax, uint32_t *ebx, uint32_t *ecx, uint32_t *edx);
--
2.1.0
reply other threads:[~2015-04-24 19:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429902726-31669-1-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).