From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Andreas Färber" <afaerber@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 1/3] target-i386: Coding style fix on x86_cpuid_set_vendor()
Date: Fri, 24 Apr 2015 16:37:30 -0300 [thread overview]
Message-ID: <1429904252-9841-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1429904252-9841-1-git-send-email-ehabkost@redhat.com>
checkpatch.pl doesn't like the extra spaces inside the square brackets,
but the alignment makes the code easier to read. Add a "+ 0" to keep
alignment while making checkpatch.pl happy.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 07465ac..11da4b5 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1640,7 +1640,7 @@ static void x86_cpuid_set_vendor(Object *obj, const char *value,
env->cpuid_vendor2 = 0;
env->cpuid_vendor3 = 0;
for (i = 0; i < 4; i++) {
- env->cpuid_vendor1 |= ((uint8_t)value[i ]) << (8 * i);
+ env->cpuid_vendor1 |= ((uint8_t)value[i + 0]) << (8 * i);
env->cpuid_vendor2 |= ((uint8_t)value[i + 4]) << (8 * i);
env->cpuid_vendor3 |= ((uint8_t)value[i + 8]) << (8 * i);
}
--
2.1.0
next prev parent reply other threads:[~2015-04-24 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 19:37 [Qemu-devel] [PATCH 0/3] target-i386: Move CPUID fields to X86CPU Eduardo Habkost
2015-04-24 19:37 ` Eduardo Habkost [this message]
2015-04-24 19:37 ` [Qemu-devel] [PATCH 2/3] target-i386: Add a marker to the end of region zeroed on reset Eduardo Habkost
2015-04-24 19:37 ` [Qemu-devel] [PATCH 3/3] target-i386: Move CPUID fields to X86CPU Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429904252-9841-2-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).