* [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
@ 2015-04-26 22:04 Emilio G. Cota
2015-04-27 2:18 ` Peter Crosthwaite
2015-04-27 15:40 ` Paolo Bonzini
0 siblings, 2 replies; 5+ messages in thread
From: Emilio G. Cota @ 2015-04-26 22:04 UTC (permalink / raw)
To: qemu-devel; +Cc: Laszlo Ersek
It's defined in osdep.h and shouldn't be redefined here.
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
tests/i440fx-test.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
index d0bc8de..33a7ecb 100644
--- a/tests/i440fx-test.c
+++ b/tests/i440fx-test.c
@@ -27,8 +27,6 @@
#define BROKEN 1
-#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
-
typedef struct TestData
{
int num_cpus;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
2015-04-26 22:04 [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition Emilio G. Cota
@ 2015-04-27 2:18 ` Peter Crosthwaite
2015-04-27 15:39 ` Emilio G. Cota
2015-04-27 15:40 ` Paolo Bonzini
1 sibling, 1 reply; 5+ messages in thread
From: Peter Crosthwaite @ 2015-04-27 2:18 UTC (permalink / raw)
To: Emilio G. Cota; +Cc: Laszlo Ersek, qemu-devel@nongnu.org Developers
On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota <cota@braap.org> wrote:
> It's defined in osdep.h and shouldn't be redefined here.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
It looks like there may be another one too:
hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
Regards,
Peter
> ---
> tests/i440fx-test.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index d0bc8de..33a7ecb 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -27,8 +27,6 @@
>
> #define BROKEN 1
>
> -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
> -
> typedef struct TestData
> {
> int num_cpus;
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
2015-04-27 2:18 ` Peter Crosthwaite
@ 2015-04-27 15:39 ` Emilio G. Cota
0 siblings, 0 replies; 5+ messages in thread
From: Emilio G. Cota @ 2015-04-27 15:39 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: Laszlo Ersek, qemu-devel@nongnu.org Developers
On Sun, Apr 26, 2015 at 19:18:41 -0700, Peter Crosthwaite wrote:
> On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota <cota@braap.org> wrote:
> > It's defined in osdep.h and shouldn't be redefined here.
> >
> > Signed-off-by: Emilio G. Cota <cota@braap.org>
>
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Thanks for having a look!
> It looks like there may be another one too:
>
> hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
That one is protected by #ifndef ARRAY_SIZE and AFAICT the file does not
include any qemu headers, so we can safely leave it as is.
Emilio
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
2015-04-26 22:04 [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition Emilio G. Cota
2015-04-27 2:18 ` Peter Crosthwaite
@ 2015-04-27 15:40 ` Paolo Bonzini
2015-04-29 6:31 ` Michael Tokarev
1 sibling, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2015-04-27 15:40 UTC (permalink / raw)
To: Emilio G. Cota, qemu-devel; +Cc: qemu-trivial@nongnu.org, Laszlo Ersek
On 27/04/2015 00:04, Emilio G. Cota wrote:
> It's defined in osdep.h and shouldn't be redefined here.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> tests/i440fx-test.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index d0bc8de..33a7ecb 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -27,8 +27,6 @@
>
> #define BROKEN 1
>
> -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
> -
> typedef struct TestData
> {
> int num_cpus;
>
Looks good; I am CCing qemu-trivial@nongnu.org so that Michael will
notice this patch.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-29 6:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-26 22:04 [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition Emilio G. Cota
2015-04-27 2:18 ` Peter Crosthwaite
2015-04-27 15:39 ` Emilio G. Cota
2015-04-27 15:40 ` Paolo Bonzini
2015-04-29 6:31 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).