From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymgt2-0004xU-C6 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 07:07:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymgt1-0004EU-Hv for qemu-devel@nongnu.org; Mon, 27 Apr 2015 07:07:40 -0400 From: Max Reitz Date: Mon, 27 Apr 2015 13:07:31 +0200 Message-Id: <1430132851-26073-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH] block/mirror: Always call block_job_sleep_ns() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz The mirror block job is trying to take a clever shortcut if delay_ns is 0 and skips block_job_sleep_ns() in that case. But that function must be called in every block job iteration, because otherwise it is for example impossible to pause the job. Signed-off-by: Max Reitz --- This makes test 129 pass when run in tmpfs (for me, at least). --- block/mirror.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index d53e60e..58f391a 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -482,9 +482,6 @@ static void coroutine_fn mirror_run(void *opaque) continue; } else if (cnt != 0) { delay_ns = mirror_iteration(s); - if (delay_ns == 0) { - continue; - } } } -- 2.3.5