qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, stefanha@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH 17/29] cputlb: remove useless arguments to tlb_unprotect_code_phys, rename
Date: Mon, 27 Apr 2015 18:28:25 +0200	[thread overview]
Message-ID: <1430152117-100558-18-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1430152117-100558-1-git-send-email-pbonzini@redhat.com>

These days modification of the TLB is done in notdirty_mem_write,
so the virtual address and env pointer as unnecessary.

The new name of the function, tlb_unprotect_code, is consistent with
tlb_protect_code.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 cputlb.c              | 3 +--
 include/exec/cputlb.h | 3 +--
 translate-all.c       | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/cputlb.c b/cputlb.c
index 38f2151..a86e76f 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -131,8 +131,7 @@ void tlb_protect_code(ram_addr_t ram_addr)
 
 /* update the TLB so that writes in physical page 'phys_addr' are no longer
    tested for self modifying code */
-void tlb_unprotect_code_phys(CPUState *cpu, ram_addr_t ram_addr,
-                             target_ulong vaddr)
+void tlb_unprotect_code(ram_addr_t ram_addr)
 {
     cpu_physical_memory_set_dirty_flag(ram_addr, DIRTY_MEMORY_CODE);
 }
diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h
index e0da9d7..360815e 100644
--- a/include/exec/cputlb.h
+++ b/include/exec/cputlb.h
@@ -22,8 +22,7 @@
 #if !defined(CONFIG_USER_ONLY)
 /* cputlb.c */
 void tlb_protect_code(ram_addr_t ram_addr);
-void tlb_unprotect_code_phys(CPUState *cpu, ram_addr_t ram_addr,
-                             target_ulong vaddr);
+void tlb_unprotect_code(ram_addr_t ram_addr);
 void tlb_reset_dirty_range(CPUTLBEntry *tlb_entry, uintptr_t start,
                            uintptr_t length);
 void cpu_tlb_reset_dirty_all(ram_addr_t start1, ram_addr_t length);
diff --git a/translate-all.c b/translate-all.c
index bfa8202..0283edc 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1158,7 +1158,7 @@ void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
     if (!p->first_tb) {
         invalidate_page_bitmap(p);
         if (is_cpu_write_access) {
-            tlb_unprotect_code_phys(cpu, start, cpu->mem_io_vaddr);
+            tlb_unprotect_code(start);
         }
     }
 #endif
-- 
1.8.3.1

  parent reply	other threads:[~2015-04-27 16:30 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 16:28 [Qemu-devel] [PATCH v2 00/29] Dirty bitmap atomic access and optimizations Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 01/29] memory: the only dirty memory flag for users is DIRTY_MEMORY_VGA Paolo Bonzini
2015-05-26  7:00   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 02/29] g364fb: remove pointless call to memory_region_set_coalescing Paolo Bonzini
2015-05-26 12:53   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 03/29] display: enable DIRTY_MEMORY_VGA tracking explicitly Paolo Bonzini
2015-05-26  7:13   ` Fam Zheng
2015-05-26  8:14     ` Paolo Bonzini
2015-05-26 11:24   ` Paolo Bonzini
2015-05-26 11:52     ` Peter Maydell
2015-05-26 11:56       ` Paolo Bonzini
2015-05-26 12:08         ` Peter Maydell
2015-05-26 12:10           ` Paolo Bonzini
2015-05-26 12:16             ` Peter Maydell
2015-05-31 20:32         ` Mark Cave-Ayland
2015-04-27 16:28 ` [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bitmap calls Paolo Bonzini
2015-05-26  7:36   ` Fam Zheng
2015-05-26  8:14     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 05/29] memory: differentiate memory_region_is_logging and memory_region_get_dirty_log_mask Paolo Bonzini
2015-05-26  7:46   ` Fam Zheng
2015-05-26 11:35     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 06/29] memory: prepare for multiple bits in the dirty log mask Paolo Bonzini
2015-05-26  7:55   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 07/29] framebuffer: check memory_region_is_logging Paolo Bonzini
2015-05-26  8:02   ` Fam Zheng
2015-05-26 11:16     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 08/29] ui/console: remove dpy_gfx_update_dirty Paolo Bonzini
2015-05-26  8:03   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 09/29] memory: track DIRTY_MEMORY_CODE in mr->dirty_log_mask Paolo Bonzini
2015-05-26  8:06   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 10/29] kvm: accept non-mapped memory in kvm_dirty_pages_log_change Paolo Bonzini
2015-05-26  8:10   ` Fam Zheng
2015-05-26  8:16     ` Paolo Bonzini
2015-05-26  8:22       ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 11/29] memory: include DIRTY_MEMORY_MIGRATION in the dirty log mask Paolo Bonzini
2015-05-26  8:40   ` Fam Zheng
2015-05-26  9:07     ` Paolo Bonzini
2015-05-26  9:22       ` Fam Zheng
2015-05-26  9:26         ` Paolo Bonzini
2015-05-26  9:48           ` Fam Zheng
2015-05-26  9:07     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 12/29] kvm: remove special handling of " Paolo Bonzini
2015-05-26  8:56   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 13/29] ram_addr: tweaks to xen_modified_memory Paolo Bonzini
2015-05-26 12:52   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 14/29] exec: use memory_region_get_dirty_log_mask to optimize dirty tracking Paolo Bonzini
2015-05-26 10:42   ` Fam Zheng
2015-05-26 10:58     ` Paolo Bonzini
2015-05-26 11:12       ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 15/29] exec: move functions to translate-all.h Paolo Bonzini
2015-05-26 10:50   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 16/29] translate-all: remove unnecessary argument to tb_invalidate_phys_range Paolo Bonzini
2015-05-26 10:51   ` Fam Zheng
2015-04-27 16:28 ` Paolo Bonzini [this message]
2015-05-26 10:53   ` [Qemu-devel] [PATCH 17/29] cputlb: remove useless arguments to tlb_unprotect_code_phys, rename Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 18/29] translate-all: make less of tb_invalidate_phys_page_range depend on is_cpu_write_access Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 19/29] exec: pass client mask to cpu_physical_memory_set_dirty_range Paolo Bonzini
2015-05-26 11:08   ` Fam Zheng
2015-05-26 11:28     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 20/29] exec: invert return value of cpu_physical_memory_get_clean, rename Paolo Bonzini
2015-05-26 11:26   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 21/29] exec: only check relevant bitmaps for cleanliness Paolo Bonzini
2015-05-26 11:31   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 22/29] memory: do not touch code dirty bitmap unless TCG is enabled Paolo Bonzini
2015-05-26 11:33   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 23/29] bitmap: add atomic set functions Paolo Bonzini
2015-05-26 11:54   ` Fam Zheng
2015-05-26 11:58     ` Paolo Bonzini
2015-05-26 12:36     ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 24/29] bitmap: add atomic test and clear Paolo Bonzini
2015-05-26 12:27   ` Fam Zheng
2015-05-26 12:32     ` Fam Zheng
2015-05-26 12:33     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 25/29] memory: use atomic ops for setting dirty memory bits Paolo Bonzini
2015-05-26 12:29   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 26/29] migration: move dirty bitmap sync to ram_addr.h Paolo Bonzini
2015-05-26 12:34   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 27/29] memory: replace cpu_physical_memory_reset_dirty() with test-and-clear Paolo Bonzini
2015-05-26 12:42   ` Fam Zheng
2015-05-26 12:45     ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 28/29] memory: make cpu_physical_memory_sync_dirty_bitmap() fully atomic Paolo Bonzini
2015-05-26 12:45   ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 29/29] memory: strengthen assertions on mr->terminates Paolo Bonzini
2015-05-26 12:49   ` Fam Zheng
2015-05-26 12:52     ` Paolo Bonzini
2015-05-26 12:56       ` Fam Zheng
2015-05-25 21:50 ` [Qemu-devel] [PATCH v2 00/29] Dirty bitmap atomic access and optimizations Paolo Bonzini
2015-05-26 12:58 ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430152117-100558-18-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).