From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmlvD-0001f8-Ff for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:30:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymlv8-0002um-Gn for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:30:15 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:35080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymlv8-0002uU-Az for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:30:10 -0400 Received: by widdi4 with SMTP id di4so106386680wid.0 for ; Mon, 27 Apr 2015 09:30:09 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 27 Apr 2015 18:28:10 +0200 Message-Id: <1430152117-100558-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 02/29] g364fb: remove pointless call to memory_region_set_coalescing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, stefanha@redhat.com, mst@redhat.com Coalescing work on MMIO, not RAM, thus this call has no effect. Signed-off-by: Paolo Bonzini --- hw/display/g364fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 46f7b41..6543f2f 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -489,7 +489,6 @@ static void g364fb_init(DeviceState *dev, G364State *s) memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram", s->vram_size, s->vram); vmstate_register_ram(&s->mem_vram, dev); - memory_region_set_coalescing(&s->mem_vram); } #define TYPE_G364 "sysbus-g364" -- 1.8.3.1