From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH 2/3] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn()
Date: Mon, 27 Apr 2015 17:00:32 -0300 [thread overview]
Message-ID: <1430164833-21006-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1430164833-21006-1-git-send-email-ehabkost@redhat.com>
One small step in the simplification of cpu_exec_init().
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
exec.c | 2 --
qom/cpu.c | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index 3566d8f..8d5d844 100644
--- a/exec.c
+++ b/exec.c
@@ -545,8 +545,6 @@ void cpu_exec_init(CPUArchState *env)
cpu_index++;
}
cpu->cpu_index = cpu_index;
- QTAILQ_INIT(&cpu->breakpoints);
- QTAILQ_INIT(&cpu->watchpoints);
#ifndef CONFIG_USER_ONLY
cpu->as = &address_space_memory;
cpu->thread_id = qemu_get_thread_id();
diff --git a/qom/cpu.c b/qom/cpu.c
index 108bfa2..56c53a8 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -313,6 +313,8 @@ static void cpu_common_initfn(Object *obj)
CPUClass *cc = CPU_GET_CLASS(obj);
cpu->gdb_num_regs = cpu->gdb_num_g_regs = cc->gdb_num_core_regs;
+ QTAILQ_INIT(&cpu->breakpoints);
+ QTAILQ_INIT(&cpu->watchpoints);
}
static int64_t cpu_common_get_arch_id(CPUState *cpu)
--
2.1.0
next prev parent reply other threads:[~2015-04-27 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 20:00 [Qemu-devel] [PATCH 0/3] cpu_exec_init() cleanups Eduardo Habkost
2015-04-27 20:00 ` [Qemu-devel] [PATCH 1/3] cpu: No need to zero-initialize numa_node Eduardo Habkost
2015-04-27 20:00 ` Eduardo Habkost [this message]
2015-04-27 20:00 ` [Qemu-devel] [PATCH 3/3] cpu: Reorder cpu->as, cpu->thread_id, cpu->memory_dispatch init Eduardo Habkost
2015-04-27 21:36 ` [Qemu-devel] [PATCH 0/3] cpu_exec_init() cleanups Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430164833-21006-3-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).