From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1YmymU-0000SG-GH
	for qemu-devel@nongnu.org; Tue, 28 Apr 2015 02:14:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1YmymQ-0003wr-GT
	for qemu-devel@nongnu.org; Tue, 28 Apr 2015 02:14:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41970)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1YmymQ-0003wh-89
	for qemu-devel@nongnu.org; Tue, 28 Apr 2015 02:14:02 -0400
Date: Tue, 28 Apr 2015 14:13:20 +0800
From: Jason Wang <jasowang@redhat.com>
Message-Id: <1430201600.5354.0@smtp.corp.redhat.com>
In-Reply-To: <20150428071225-mutt-send-email-mst@redhat.com>
References: <1429770109-23873-1-git-send-email-jasowang@redhat.com>
	<1429770109-23873-9-git-send-email-jasowang@redhat.com>
	<20150427130441-mutt-send-email-mst@redhat.com>
	<1430190844.9163.3@smtp.corp.redhat.com>
	<20150428071225-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Subject: Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific
 queue limit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>



On Tue, Apr 28, 2015 at 1:13 PM, Michael S. Tsirkin <mst@redhat.com> 
wrote:
> On Tue, Apr 28, 2015 at 11:14:04AM +0800, Jason Wang wrote:
>>  
>>  
>>  On Mon, Apr 27, 2015 at 7:05 PM, Michael S. Tsirkin 
>> <mst@redhat.com> wrote:
>>  >On Thu, Apr 23, 2015 at 02:21:41PM +0800, Jason Wang wrote:
>>  >> This patch introduces a bus specific queue limitation. It will be
>>  >> useful for increasing the limit for one of the bus without 
>> disturbing
>>  >> other buses.
>>  >> Cc: Michael S. Tsirkin <mst@redhat.com>
>>  >> Cc: Alexander Graf <agraf@suse.de>
>>  >> Cc: Richard Henderson <rth@twiddle.net>
>>  >> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
>>  >> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
>>  >> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>  >> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>  >> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>>  >
>>  >Is this still needed if you drop the attempt to
>>  >keep the limit around for old machine types?
>>  
>>  If we agree to drop, we probably need transport specific macro.
> 
> You mean just rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX?
> Fine, why not.

I mean keeping VIRTIO_PCI_QUEUE_MAX for pci only and just increase pci 
limit. And introduce e.g VIRTIO_PCI_QUEUE_CCW for ccw and keep it as 
64. Since to my understanding, it's not safe to increase the limit for 
all other transports which was pointed out by Cornelia in V1: 
http://permalink.gmane.org/gmane.comp.emulators.qemu/318245.