From: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 21/27] iotests, parallels: check for incorrectly closed image in tests
Date: Tue, 28 Apr 2015 10:46:54 +0300 [thread overview]
Message-ID: <1430207220-24458-22-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1430207220-24458-1-git-send-email-den@openvz.org>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Roman Kagan <rkagan@parallels.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/131 | 9 +++++++++
tests/qemu-iotests/131.out | 17 +++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/tests/qemu-iotests/131 b/tests/qemu-iotests/131
index f45afa7..4873f40 100755
--- a/tests/qemu-iotests/131
+++ b/tests/qemu-iotests/131
@@ -42,6 +42,8 @@ _supported_fmt parallels
_supported_proto file
_supported_os Linux
+inuse_offset=$((0x2c))
+
size=64M
CLUSTER_SIZE=64k
IMGFMT=parallels
@@ -62,6 +64,13 @@ echo == check that there is no trash after written ==
echo == check that there is no trash before written ==
{ $QEMU_IO -c "read -P 0 0 32k" "$TEST_IMG"; } 2>&1 | _filter_qemu_io | _filter_testdir
+echo "== Corrupt image =="
+poke_file "$TEST_IMG" "$inuse_offset" "\x59\x6e\x6f\x74"
+{ $QEMU_IO -c "read -P 0x11 64k 64k" "$TEST_IMG"; } 2>&1 | _filter_qemu_io | _filter_testdir
+_check_test_img
+_check_test_img -r all
+{ $QEMU_IO -c "read -P 0x11 64k 64k" "$TEST_IMG"; } 2>&1 | _filter_qemu_io | _filter_testdir
+
# success, all done
echo "*** done"
rm -f $seq.full
diff --git a/tests/qemu-iotests/131.out b/tests/qemu-iotests/131.out
index 4158a2f..021a04c 100644
--- a/tests/qemu-iotests/131.out
+++ b/tests/qemu-iotests/131.out
@@ -21,4 +21,21 @@ read 32768/32768 bytes at offset 163840
== check that there is no trash before written ==
read 32768/32768 bytes at offset 0
32 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+== Corrupt image ==
+qemu-io: can't open device TEST_DIR/t.parallels: parallels: Image was not closed correctly; cannot be opened read/write
+no file open, try 'help open'
+ERROR image was not closed correctly
+
+1 errors were found on the image.
+Data may be corrupted, or further writes to the image may corrupt it.
+Repairing image was not closed correctly
+The following inconsistencies were found and repaired:
+
+ 0 leaked clusters
+ 1 corruptions
+
+Double checking the fixed image now...
+No errors were found on the image.
+read 65536/65536 bytes at offset 65536
+64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
*** done
--
1.9.1
next prev parent reply other threads:[~2015-04-28 7:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 7:46 [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 01/27] iotests, parallels: quote TEST_IMG in 076 test to be path-safe Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 02/27] block/parallels: rename parallels_header to ParallelsHeader Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read Denis V. Lunev
2015-05-18 16:11 ` Stefan Hajnoczi
2015-04-28 7:46 ` [Qemu-devel] [PATCH 04/27] block/parallels: read up to cluster end in one go Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status Denis V. Lunev
2015-05-18 16:11 ` Stefan Hajnoczi
2015-04-28 7:46 ` [Qemu-devel] [PATCH 06/27] block/parallels: provide _co_readv routine for parallels format driver Denis V. Lunev
2015-04-28 9:26 ` Roman Kagan
2015-05-18 16:12 ` Stefan Hajnoczi
2015-04-28 7:46 ` [Qemu-devel] [PATCH 07/27] block/parallels: replace magic constants 4, 64 with proper sizeofs Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 08/27] block/parallels: mark parallels format driver as zero inited Denis V. Lunev
2015-04-28 9:53 ` Roman Kagan
2015-05-18 16:13 ` Stefan Hajnoczi
2015-04-28 7:46 ` [Qemu-devel] [PATCH 09/27] block/parallels: _co_writev callback for Parallels format Denis V. Lunev
2015-04-28 10:40 ` Roman Kagan
2015-05-18 16:29 ` Stefan Hajnoczi
2015-04-28 7:46 ` [Qemu-devel] [PATCH 10/27] iotests, parallels: test for write into Parallels image Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 11/27] block/parallels: support parallels image creation Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 12/27] iotests, parallels: test for newly created parallels image via qemu-img Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 13/27] parallels: change copyright information in the image header Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 14/27] block/parallels: rename catalog_ names to bat_ Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 15/27] block/parallels: create bat2sect helper Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 16/27] block/parallels: keep BAT bitmap data in little endian in memory Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 17/27] block/parallels: read parallels image header and BAT into single buffer Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 18/27] block/parallels: move parallels_open/probe to the very end of the file Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 19/27] block/parallels: implement parallels_check method of block driver Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 20/27] block/parallels: implement incorrect close detection Denis V. Lunev
2015-04-28 7:46 ` Denis V. Lunev [this message]
2015-04-28 7:46 ` [Qemu-devel] [PATCH 22/27] block/parallels: improve image reading performance Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 23/27] block/parallels: create bat_entry_off helper Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 24/27] block/parallels: delay writing to BAT till bdrv_co_flush_to_os Denis V. Lunev
2015-04-28 7:46 ` [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets Denis V. Lunev
2015-04-28 10:59 ` Roman Kagan
2015-04-29 11:20 ` Roman Kagan
2015-05-18 16:32 ` Stefan Hajnoczi
2015-04-28 7:46 ` [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion Denis V. Lunev
2015-04-28 11:00 ` Roman Kagan
2015-05-18 16:32 ` Stefan Hajnoczi
2015-04-28 7:47 ` [Qemu-devel] [PATCH 27/27] block/parallels: improve image writing performance further Denis V. Lunev
2015-05-18 16:33 ` Stefan Hajnoczi
2015-05-08 17:39 ` [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-05-18 8:24 ` Denis V. Lunev
2015-05-18 16:45 ` Stefan Hajnoczi
2015-05-19 8:26 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430207220-24458-22-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).