qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org,
	pbonzini@redhat.com, peter.crosthwaite@xilinx.com
Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
	christoffer.dall@linaro.org, patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/3] Extend check callback usability for irq connect notifier
Date: Tue, 28 Apr 2015 10:18:00 +0100	[thread overview]
Message-ID: <1430212683-10984-1-git-send-email-eric.auger@linaro.org> (raw)

The VFIO platform device gets connected to the platform bus
on a machine init done notifier. Only at that point irqfd can be
setup. An irq connect notifier would be helpful to do that job.
Instead of adding a new callback at sysbus or qdev level, this
series proposes to use the property check() callback (credit to
Paolo).

- the callback is passed to qdev_init_gpio_out_named
- sysbus class now holds a irq_set_hook method usable as check
  callback
- sysbus_init_irq initializes the callback to the class method
- object_set_link_property is modified so that
  * the target object is populated before the check
  * check takes an Object ** enabling to access the object
    container.

Then The VFIO platform device would override the irq_set_hook
method in a separate patch.

Please let me know if those modifications are acceptable. Else
I will follow Peter's proposal. 

Best Regards

Eric

Eric Auger (3):
  qdev: pass the check callback to qdev_init_gpio_out_named
  qdev: check callback takes Object **target as third argument
  sysbus: add irq_set_hook

 hw/core/qdev-properties.c    |  2 +-
 hw/core/qdev.c               |  8 +++++---
 hw/core/sysbus.c             |  8 +++++++-
 include/hw/qdev-core.h       |  3 ++-
 include/hw/qdev-properties.h |  2 +-
 include/hw/sysbus.h          |  1 +
 include/qom/object.h         |  8 +++++---
 qom/object.c                 | 15 +++++++++------
 8 files changed, 31 insertions(+), 16 deletions(-)

-- 
1.8.3.2

             reply	other threads:[~2015-04-28  9:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28  9:18 Eric Auger [this message]
2015-04-28  9:18 ` [Qemu-devel] [PATCH 1/3] qdev: pass the check callback to qdev_init_gpio_out_named Eric Auger
2015-04-28  9:18 ` [Qemu-devel] [PATCH 2/3] qdev: check callback takes Object **target as third argument Eric Auger
2015-04-28 11:47   ` Paolo Bonzini
2015-04-28  9:18 ` [Qemu-devel] [PATCH 3/3] sysbus: add irq_set_hook Eric Auger
2015-04-28 18:21 ` [Qemu-devel] [PATCH 0/3] Extend check callback usability for irq connect notifier Peter Crosthwaite
2015-04-29  7:43   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430212683-10984-1-git-send-email-eric.auger@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@st.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).