From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn1em-00053U-G5 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 05:18:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn1ec-000326-Kk for qemu-devel@nongnu.org; Tue, 28 Apr 2015 05:18:20 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:38162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn1ec-0002zw-Es for qemu-devel@nongnu.org; Tue, 28 Apr 2015 05:18:10 -0400 Received: by wiun10 with SMTP id n10so21093030wiu.1 for ; Tue, 28 Apr 2015 02:18:09 -0700 (PDT) From: Eric Auger Date: Tue, 28 Apr 2015 10:18:00 +0100 Message-Id: <1430212683-10984-1-git-send-email-eric.auger@linaro.org> Subject: [Qemu-devel] [PATCH 0/3] Extend check callback usability for irq connect notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org, pbonzini@redhat.com, peter.crosthwaite@xilinx.com Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, patches@linaro.org The VFIO platform device gets connected to the platform bus on a machine init done notifier. Only at that point irqfd can be setup. An irq connect notifier would be helpful to do that job. Instead of adding a new callback at sysbus or qdev level, this series proposes to use the property check() callback (credit to Paolo). - the callback is passed to qdev_init_gpio_out_named - sysbus class now holds a irq_set_hook method usable as check callback - sysbus_init_irq initializes the callback to the class method - object_set_link_property is modified so that * the target object is populated before the check * check takes an Object ** enabling to access the object container. Then The VFIO platform device would override the irq_set_hook method in a separate patch. Please let me know if those modifications are acceptable. Else I will follow Peter's proposal. Best Regards Eric Eric Auger (3): qdev: pass the check callback to qdev_init_gpio_out_named qdev: check callback takes Object **target as third argument sysbus: add irq_set_hook hw/core/qdev-properties.c | 2 +- hw/core/qdev.c | 8 +++++--- hw/core/sysbus.c | 8 +++++++- include/hw/qdev-core.h | 3 ++- include/hw/qdev-properties.h | 2 +- include/hw/sysbus.h | 1 + include/qom/object.h | 8 +++++--- qom/object.c | 15 +++++++++------ 8 files changed, 31 insertions(+), 16 deletions(-) -- 1.8.3.2