From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn72c-0002Mp-Gh for qemu-devel@nongnu.org; Tue, 28 Apr 2015 11:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn72Y-0002mT-C9 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 11:03:18 -0400 From: Kevin Wolf Date: Tue, 28 Apr 2015 17:00:55 +0200 Message-Id: <1430233258-31807-74-git-send-email-kwolf@redhat.com> In-Reply-To: <1430233258-31807-1-git-send-email-kwolf@redhat.com> References: <1430233258-31807-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 73/76] block: replace bdrv_states iteration with bdrv_next() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi The bdrv_states list is a static variable in block.c. bdrv_drain_all() and bdrv_flush_all() use this variable to iterate over all drives. The next patch will move bdrv_drain_all() and bdrv_flush_all() out of block.c so it's necessary to switch to the public bdrv_next() interface. Reviewed-by: Alberto Garcia Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index ec23594..1f0a4e2 100644 --- a/block.c +++ b/block.c @@ -2051,9 +2051,9 @@ void bdrv_drain_all(void) { /* Always run first iteration so any pending completion BHs run */ bool busy = true; - BlockDriverState *bs; + BlockDriverState *bs = NULL; - QTAILQ_FOREACH(bs, &bdrv_states, device_list) { + while ((bs = bdrv_next(bs))) { AioContext *aio_context = bdrv_get_aio_context(bs); aio_context_acquire(aio_context); @@ -2065,8 +2065,9 @@ void bdrv_drain_all(void) while (busy) { busy = false; + bs = NULL; - QTAILQ_FOREACH(bs, &bdrv_states, device_list) { + while ((bs = bdrv_next(bs))) { AioContext *aio_context = bdrv_get_aio_context(bs); aio_context_acquire(aio_context); @@ -2075,7 +2076,8 @@ void bdrv_drain_all(void) } } - QTAILQ_FOREACH(bs, &bdrv_states, device_list) { + bs = NULL; + while ((bs = bdrv_next(bs))) { AioContext *aio_context = bdrv_get_aio_context(bs); aio_context_acquire(aio_context); @@ -4015,10 +4017,10 @@ int bdrv_get_flags(BlockDriverState *bs) int bdrv_flush_all(void) { - BlockDriverState *bs; + BlockDriverState *bs = NULL; int result = 0; - QTAILQ_FOREACH(bs, &bdrv_states, device_list) { + while ((bs = bdrv_next(bs))) { AioContext *aio_context = bdrv_get_aio_context(bs); int ret; -- 1.8.3.1