qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, kchamart@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support
Date: Wed, 29 Apr 2015 15:14:00 -0400	[thread overview]
Message-ID: <1430334844-7015-1-git-send-email-jsnow@redhat.com> (raw)

The qmp-shell is a little rudimentary, but it can be hacked
to give us some transactional support without too much difficulty.

(1) Prep.
(2) Add support for serializing json arrays and
    improve the robustness of QMP parsing
(3) Add a special transaction( ... ) syntax that lets users
    build up transactional commands using the existing qmp shell
    syntax to define each action.
(4) Add a verbose flag to display generated QMP commands.

The parsing is not as robust as one would like, but this suffices
without adding a proper parser.

Design considerations:

(1) Try not to disrupt the existing design of the qmp-shell. The existing
    API is not disturbed.
(2) Pick a "magic token" such that it could not be confused for legitimate
    QMP/JSON syntax. Parentheses are used for this purpose.

For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch qmp-shell++
This version is tagged qmp-shell++-v4.

===
v++
===

 - Use the AST to allow 'true', 'false' and 'null' within QMP expressions
 - Fix a bunch of stupid junk I broke in v2, apparently.

===
v3:
===

 - Folding in hotfix from list (import ast)

===
v2:
===

 - Squash patches 2 & 3:
 - Remove wholesale replacement of single quotes, in favor of try blocks
   that attempt to parse as pure JSON, then as Python.
 - Factored out the value parser block to accomplish the above.
 - Allow both true/True and false/False for values.
 - Fix typo in patch 3 cover letter. (was patch 4.)

John Snow (4):
  scripts: qmp-shell: refactor helpers
  scripts: qmp-shell: Expand support for QMP expressions
  scripts: qmp-shell: add transaction subshell
  scripts: qmp-shell: Add verbose flag

 scripts/qmp/qmp-shell | 147 +++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 116 insertions(+), 31 deletions(-)

-- 
2.1.0

             reply	other threads:[~2015-04-29 19:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 19:14 John Snow [this message]
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 1/4] scripts: qmp-shell: refactor helpers John Snow
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 2/4] scripts: qmp-shell: Expand support for QMP expressions John Snow
2015-04-29 19:25   ` Eric Blake
2015-04-29 20:09     ` John Snow
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 3/4] scripts: qmp-shell: add transaction subshell John Snow
2015-04-29 19:34   ` Eric Blake
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag John Snow
2015-04-29 19:35   ` Eric Blake
2015-04-30  9:06 ` [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support Kashyap Chamarthy
2015-05-04 19:24 ` John Snow
2015-05-05 12:52   ` Luiz Capitulino
2015-05-05 15:34     ` John Snow
2015-05-05 20:14       ` Luiz Capitulino
2015-05-08 12:47 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430334844-7015-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).