qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, afaerber@suse.de, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 21/32] spapr: add rtas_st_buffer_direct() helper
Date: Fri,  1 May 2015 16:41:39 +1000	[thread overview]
Message-ID: <1430462510-14195-22-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1430462510-14195-1-git-send-email-david@gibson.dropbear.id.au>

From: Michael Roth <mdroth@linux.vnet.ibm.com>

This is similar to the existing rtas_st_buffer(), but for cases
where the guest is not expecting a length-encoded byte array.
Namely, for calls where a "work area" buffer is used to pass
around arbitrary fields/data.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 include/hw/ppc/spapr.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 8810911..65ef7dd 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -464,6 +464,13 @@ static inline void rtas_st(target_ulong phys, int n, uint32_t val)
     stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n), val);
 }
 
+static inline void rtas_st_buffer_direct(target_ulong phys,
+                                         target_ulong phys_len,
+                                         uint8_t *buffer, uint16_t buffer_len)
+{
+    cpu_physical_memory_write(ppc64_phys_to_real(phys), buffer,
+                              MIN(buffer_len, phys_len));
+}
 
 static inline void rtas_st_buffer(target_ulong phys, target_ulong phys_len,
                                   uint8_t *buffer, uint16_t buffer_len)
@@ -473,8 +480,7 @@ static inline void rtas_st_buffer(target_ulong phys, target_ulong phys_len,
     }
     stw_be_phys(&address_space_memory,
                 ppc64_phys_to_real(phys), buffer_len);
-    cpu_physical_memory_write(ppc64_phys_to_real(phys + 2),
-                              buffer, MIN(buffer_len, phys_len - 2));
+    rtas_st_buffer_direct(phys + 2, phys_len - 2, buffer, buffer_len);
 }
 
 typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, sPAPREnvironment *spapr,
-- 
2.1.0

  parent reply	other threads:[~2015-05-01  6:42 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  6:41 [Qemu-devel] [PATCH 00/32] Accumulated -machine pseries patches 2015/05/01 David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 01/32] spapr_pci: Fix unsafe signed/unsigned comparisons David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 02/32] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 03/32] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 04/32] spapr_pci: Introduce a liobn number generating macros David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 05/32] spapr_vio: " David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 06/32] spapr_pci: Define default DMA window size as a macro David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 07/32] spapr_iommu: Add separate trace points for PCI DMA operations David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 08/32] spapr_pci: Make find_phb()/find_dev() public David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 09/32] spapr_iommu: Make spapr_tce_find_by_liobn() public David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 10/32] spapr_pci: Rework device-tree rendering David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 11/32] spapr_iommu: Give unique QOM name to TCE table David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 12/32] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 13/32] pseries: Add pseries-2.4 machine type David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 14/32] hw/ppc/spapr: Fix error message when firmware could not be loaded David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 15/32] hw/ppc/spapr: Use error_report() instead of hw_error() David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 16/32] docs: add sPAPR hotplug/dynamic-reconfiguration documentation David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 17/32] spapr_drc: initial implementation of sPAPRDRConnector device David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 18/32] spapr_rtas: add get/set-power-level RTAS interfaces David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 19/32] spapr_rtas: add set-indicator RTAS interface David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 20/32] spapr_rtas: add get-sensor-state " David Gibson
2015-05-01  6:41 ` David Gibson [this message]
2015-05-01  6:41 ` [Qemu-devel] [PATCH 22/32] spapr_rtas: add ibm, configure-connector " David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 23/32] spapr_events: re-use EPOW event infrastructure for hotplug events David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 24/32] spapr_events: event-scan RTAS interface David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 25/32] spapr_drc: add spapr_drc_populate_dt() David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 26/32] spapr_pci: add dynamic-reconfiguration option for spapr-pci-host-bridge David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 27/32] spapr_pci: create DRConnectors for each PCI slot during PHB realize David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 28/32] pci: make pci_bar useable outside pci.c David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 29/32] spapr_pci: enable basic hotplug operations David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 30/32] spapr_pci: emit hotplug add/remove events during hotplug David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 31/32] machine: add default_ram_size to machine class David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 32/32] spapr: override default ram size to 512MB David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430462510-14195-22-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).