qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, afaerber@suse.de, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 28/32] pci: make pci_bar useable outside pci.c
Date: Fri,  1 May 2015 16:41:46 +1000	[thread overview]
Message-ID: <1430462510-14195-29-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1430462510-14195-1-git-send-email-david@gibson.dropbear.id.au>

From: Michael Roth <mdroth@linux.vnet.ibm.com>

We need to work with PCI BARs to generate OF properties
during PCI hotplug for sPAPR guests.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/pci/pci.c         | 2 +-
 include/hw/pci/pci.h | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index b3d5100..e57255e 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -123,7 +123,7 @@ static uint16_t pci_default_sub_device_id = PCI_SUBDEVICE_ID_QEMU;
 
 static QLIST_HEAD(, PCIHostState) pci_host_bridges;
 
-static int pci_bar(PCIDevice *d, int reg)
+int pci_bar(PCIDevice *d, int reg)
 {
     uint8_t type;
 
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index d4ffead..a733ba4 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -333,6 +333,12 @@ int pci_device_load(PCIDevice *s, QEMUFile *f);
 MemoryRegion *pci_address_space(PCIDevice *dev);
 MemoryRegion *pci_address_space_io(PCIDevice *dev);
 
+/*
+ * Should not normally be used by devices. For use by sPAPR target
+ * where QEMU emulates firmware.
+ */
+int pci_bar(PCIDevice *d, int reg);
+
 typedef void (*pci_set_irq_fn)(void *opaque, int irq_num, int level);
 typedef int (*pci_map_irq_fn)(PCIDevice *pci_dev, int irq_num);
 typedef PCIINTxRoute (*pci_route_irq_fn)(void *opaque, int pin);
-- 
2.1.0

  parent reply	other threads:[~2015-05-01  6:42 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  6:41 [Qemu-devel] [PATCH 00/32] Accumulated -machine pseries patches 2015/05/01 David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 01/32] spapr_pci: Fix unsafe signed/unsigned comparisons David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 02/32] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 03/32] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 04/32] spapr_pci: Introduce a liobn number generating macros David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 05/32] spapr_vio: " David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 06/32] spapr_pci: Define default DMA window size as a macro David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 07/32] spapr_iommu: Add separate trace points for PCI DMA operations David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 08/32] spapr_pci: Make find_phb()/find_dev() public David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 09/32] spapr_iommu: Make spapr_tce_find_by_liobn() public David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 10/32] spapr_pci: Rework device-tree rendering David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 11/32] spapr_iommu: Give unique QOM name to TCE table David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 12/32] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 13/32] pseries: Add pseries-2.4 machine type David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 14/32] hw/ppc/spapr: Fix error message when firmware could not be loaded David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 15/32] hw/ppc/spapr: Use error_report() instead of hw_error() David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 16/32] docs: add sPAPR hotplug/dynamic-reconfiguration documentation David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 17/32] spapr_drc: initial implementation of sPAPRDRConnector device David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 18/32] spapr_rtas: add get/set-power-level RTAS interfaces David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 19/32] spapr_rtas: add set-indicator RTAS interface David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 20/32] spapr_rtas: add get-sensor-state " David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 21/32] spapr: add rtas_st_buffer_direct() helper David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 22/32] spapr_rtas: add ibm, configure-connector RTAS interface David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 23/32] spapr_events: re-use EPOW event infrastructure for hotplug events David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 24/32] spapr_events: event-scan RTAS interface David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 25/32] spapr_drc: add spapr_drc_populate_dt() David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 26/32] spapr_pci: add dynamic-reconfiguration option for spapr-pci-host-bridge David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 27/32] spapr_pci: create DRConnectors for each PCI slot during PHB realize David Gibson
2015-05-01  6:41 ` David Gibson [this message]
2015-05-01  6:41 ` [Qemu-devel] [PATCH 29/32] spapr_pci: enable basic hotplug operations David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 30/32] spapr_pci: emit hotplug add/remove events during hotplug David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 31/32] machine: add default_ram_size to machine class David Gibson
2015-05-01  6:41 ` [Qemu-devel] [PATCH 32/32] spapr: override default ram size to 512MB David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430462510-14195-29-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).