From: "Denis V. Lunev" <den@openvz.org>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Olga Krishtal <okrishtal@parallels.com>,
qemu-devel@nongnu.org, "Denis V. Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH 1/4] qga: added empty qmp_quest_get_fsinfo functionality.
Date: Sat, 2 May 2015 13:13:18 +0300 [thread overview]
Message-ID: <1430561601-19184-2-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1430561601-19184-1-git-send-email-den@openvz.org>
From: Olga Krishtal <okrishtal@parallels.com>
We need qmp_quest_get_fsinfo togather with vss-provider, which works with
volumes. The call to this function is implemented via
FindFirst/NextVolumes. Moreover volumes in Windows OS are filesystem unit,
so it will be more effective to work with them rather with devices.
Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/commands-win32.c | 34 +++++++++++++++++++++++++++++++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 3ef0549..1a82ec9 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -382,12 +382,40 @@ static void guest_file_init(void)
QTAILQ_INIT(&guest_file_state.filehandles);
}
-GuestFilesystemInfoList *qmp_guest_get_fsinfo(Error **errp)
+static GuestFilesystemInfo *build_guest_fsinfo(char *guid, Error **errp)
{
- error_set(errp, QERR_UNSUPPORTED);
return NULL;
}
+GuestFilesystemInfoList *qmp_guest_get_fsinfo(Error **errp)
+{
+ HANDLE vol_h;
+ GuestFilesystemInfoList *new, *ret = NULL;
+ char guid[256];
+ bool res = false;
+
+ vol_h = FindFirstVolume(guid, sizeof(guid));
+ if (vol_h == INVALID_HANDLE_VALUE) {
+ error_setg_win32(errp, GetLastError(), "failed to find any volume");
+ return NULL;
+ }
+
+ do {
+ new = g_malloc(sizeof(*ret));
+ new->value = build_guest_fsinfo(guid, errp);
+ new->next = ret;
+ ret = new;
+ res = FindNextVolume(vol_h, guid, sizeof(guid));
+ } while (res);
+
+ if (GetLastError() != ERROR_NO_MORE_FILES) {
+ error_setg_win32(errp, GetLastError(), "failed to find next volume");
+ }
+
+ FindVolumeClose(vol_h);
+ return ret;
+}
+
/*
* Return status of freeze/thaw
*/
@@ -712,7 +740,7 @@ GList *ga_command_blacklist_init(GList *blacklist)
"guest-set-user-password",
"guest-get-memory-blocks", "guest-set-memory-blocks",
"guest-get-memory-block-size",
- "guest-fsfreeze-freeze-list", "guest-get-fsinfo",
+ "guest-fsfreeze-freeze-list",
"guest-fstrim", NULL};
char **p = (char **)list_unsupported;
--
1.9.1
next prev parent reply other threads:[~2015-05-02 10:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 10:13 [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest Denis V. Lunev
2015-05-02 10:13 ` Denis V. Lunev [this message]
2015-05-02 10:13 ` [Qemu-devel] [PATCH 2/4] qga: added mountpoint and filesystem type for single Denis V. Lunev
2015-05-02 10:13 ` [Qemu-devel] [PATCH 3/4] qga: added bus type and disk location path Denis V. Lunev
2015-05-02 10:13 ` [Qemu-devel] [PATCH 4/4] qga: added GuestPCIAddress information Denis V. Lunev
2015-05-12 5:51 ` [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest Denis V. Lunev
2015-05-20 7:48 ` Denis V. Lunev
2015-05-27 7:07 ` Denis V. Lunev
2015-06-08 6:43 ` Denis V. Lunev
2015-06-15 7:07 ` Denis V. Lunev
2015-06-16 12:48 ` Stefan Hajnoczi
2015-06-16 12:57 ` Denis V. Lunev
2015-06-16 14:37 ` Eric Blake
2015-06-16 16:43 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430561601-19184-2-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@parallels.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).