From: "Denis V. Lunev" <den@openvz.org>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Olga Krishtal <okrishtal@parallels.com>,
qemu-devel@nongnu.org, "Denis V. Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH 2/4] qga: added mountpoint and filesystem type for single
Date: Sat, 2 May 2015 13:13:19 +0300 [thread overview]
Message-ID: <1430561601-19184-3-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1430561601-19184-1-git-send-email-den@openvz.org>
From: Olga Krishtal <okrishtal@parallels.com>
We should use GetVolumeXXX api to work with volumes. This will help us to
resolve the situation with volumes without drive letter, i.e. when the
volume is mounted as a folder. This case is called mounted folder.
This volume is a regular mounted volume from all other points of view.
The information about non mounted volume is reported as System Reserved.
This volume is not mounted and thus it is not writable.
GuestDiskAddressList API is not used as operations are performed with
volumess rather when with disks. This means that spanned disk will
be counted and handled as a single volume. It is worth to note
that the information about every disk in the volume can be queried
via IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS.
Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/commands-win32.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 1a82ec9..d26fd59 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -384,7 +384,48 @@ static void guest_file_init(void)
static GuestFilesystemInfo *build_guest_fsinfo(char *guid, Error **errp)
{
- return NULL;
+ DWORD info_size;
+ char mnt, *mnt_point;
+ char fs_name[32];
+ char vol_info[MAX_PATH+1];
+ size_t len;
+ GuestFilesystemInfo *fs = NULL;
+
+ GetVolumePathNamesForVolumeName(guid, mnt, NULL, &info_size);
+ if (GetLastError() != ERROR_MORE_DATA) {
+ error_setg_win32(errp, GetLastError(), "failed to get volume name");
+ return NULL;
+ }
+
+ mnt_point = g_malloc(info_size + 1);
+ if (!GetVolumePathNamesForVolumeName(guid, mnt_point, info_size,
+ &info_size)) {
+ error_setg_win32(errp, GetLastError(), "failed to get volume name");
+ goto free;
+ }
+
+ len = strlen(mnt_point);
+ mnt_point[len] = '\\';
+ mnt_point[len+1] = 0;
+ if (!GetVolumeInformation(mnt_point, vol_info, sizeof(vol_info), NULL, NULL,
+ NULL, &fs_name, sizeof(fs_name))) {
+ error_setg_win32(errp, GetLastError(), "failed to get volume info");
+ goto free;
+ }
+
+ fs_name[sizeof(fs_name) - 1] = 0;
+ fs = g_malloc(sizeof(*fs));
+ fs->name = g_strdup(guid);
+ if (len == 0) {
+ fs->mountpoint = g_strdup("System Reserved");
+ } else {
+ fs->mountpoint = g_strndup(mnt_point, len);
+ }
+ fs->type = g_strdup(fs_name);
+ fs->disk = NULL;
+free:
+ g_free(mnt_point);
+ return fs;
}
GuestFilesystemInfoList *qmp_guest_get_fsinfo(Error **errp)
--
1.9.1
next prev parent reply other threads:[~2015-05-02 10:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 10:13 [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest Denis V. Lunev
2015-05-02 10:13 ` [Qemu-devel] [PATCH 1/4] qga: added empty qmp_quest_get_fsinfo functionality Denis V. Lunev
2015-05-02 10:13 ` Denis V. Lunev [this message]
2015-05-02 10:13 ` [Qemu-devel] [PATCH 3/4] qga: added bus type and disk location path Denis V. Lunev
2015-05-02 10:13 ` [Qemu-devel] [PATCH 4/4] qga: added GuestPCIAddress information Denis V. Lunev
2015-05-12 5:51 ` [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest Denis V. Lunev
2015-05-20 7:48 ` Denis V. Lunev
2015-05-27 7:07 ` Denis V. Lunev
2015-06-08 6:43 ` Denis V. Lunev
2015-06-15 7:07 ` Denis V. Lunev
2015-06-16 12:48 ` Stefan Hajnoczi
2015-06-16 12:57 ` Denis V. Lunev
2015-06-16 14:37 ` Eric Blake
2015-06-16 16:43 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430561601-19184-3-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@parallels.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).