* [Qemu-devel] [PATCH v1 1/1] hw/ptimer: Do not artificially limit timers when using icount
@ 2015-05-04 3:18 Edgar E. Iglesias
2015-05-04 9:27 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2015-05-04 3:18 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, pbonzini
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/core/ptimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index 2abad1f..8437bd6 100644
--- a/hw/core/ptimer.c
+++ b/hw/core/ptimer.c
@@ -189,7 +189,7 @@ void ptimer_set_limit(ptimer_state *s, uint64_t limit, int reload)
* on the current generation of host machines.
*/
- if (limit * s->period < 10000 && s->period) {
+ if (!use_icount && limit * s->period < 10000 && s->period) {
limit = 10000 / s->period;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] hw/ptimer: Do not artificially limit timers when using icount
2015-05-04 3:18 [Qemu-devel] [PATCH v1 1/1] hw/ptimer: Do not artificially limit timers when using icount Edgar E. Iglesias
@ 2015-05-04 9:27 ` Paolo Bonzini
2015-05-08 7:35 ` Edgar E. Iglesias
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2015-05-04 9:27 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel; +Cc: peter.maydell
On 04/05/2015 05:18, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/core/ptimer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
> index 2abad1f..8437bd6 100644
> --- a/hw/core/ptimer.c
> +++ b/hw/core/ptimer.c
> @@ -189,7 +189,7 @@ void ptimer_set_limit(ptimer_state *s, uint64_t limit, int reload)
> * on the current generation of host machines.
> */
>
> - if (limit * s->period < 10000 && s->period) {
> + if (!use_icount && limit * s->period < 10000 && s->period) {
> limit = 10000 / s->period;
> }
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] hw/ptimer: Do not artificially limit timers when using icount
2015-05-04 9:27 ` Paolo Bonzini
@ 2015-05-08 7:35 ` Edgar E. Iglesias
0 siblings, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2015-05-08 7:35 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: peter.maydell, qemu-devel
On Mon, May 04, 2015 at 11:27:36AM +0200, Paolo Bonzini wrote:
>
>
> On 04/05/2015 05:18, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
> > hw/core/ptimer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
> > index 2abad1f..8437bd6 100644
> > --- a/hw/core/ptimer.c
> > +++ b/hw/core/ptimer.c
> > @@ -189,7 +189,7 @@ void ptimer_set_limit(ptimer_state *s, uint64_t limit, int reload)
> > * on the current generation of host machines.
> > */
> >
> > - if (limit * s->period < 10000 && s->period) {
> > + if (!use_icount && limit * s->period < 10000 && s->period) {
> > limit = 10000 / s->period;
> > }
> >
> >
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks, I've applied this one.
Cheers,
Edgar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-08 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-04 3:18 [Qemu-devel] [PATCH v1 1/1] hw/ptimer: Do not artificially limit timers when using icount Edgar E. Iglesias
2015-05-04 9:27 ` Paolo Bonzini
2015-05-08 7:35 ` Edgar E. Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).