From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, berto@igalia.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH v8 04/40] qapi: Fix generation of 'size' builtin type
Date: Mon, 4 May 2015 09:05:01 -0600 [thread overview]
Message-ID: <1430751937-17523-5-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1430751937-17523-1-git-send-email-eblake@redhat.com>
We were missing the 'size' builtin type (which means that QAPI using
[ 'size' ] would fail to compile).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi.py | 1 +
tests/qapi-schema/qapi-schema-test.json | 3 ++-
tests/qapi-schema/qapi-schema-test.out | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 2b5775d..d470347 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -29,6 +29,7 @@ builtin_types = {
'uint16': 'QTYPE_QINT',
'uint32': 'QTYPE_QINT',
'uint64': 'QTYPE_QINT',
+ 'size': 'QTYPE_QINT',
}
def error_path(parent):
diff --git a/tests/qapi-schema/qapi-schema-test.json b/tests/qapi-schema/qapi-schema-test.json
index d43b5fd..84f0f07 100644
--- a/tests/qapi-schema/qapi-schema-test.json
+++ b/tests/qapi-schema/qapi-schema-test.json
@@ -74,7 +74,8 @@
'u64': ['uint64'],
'number': ['number'],
'boolean': ['bool'],
- 'string': ['str'] } }
+ 'string': ['str'],
+ 'sizes': ['size'] } }
# testing commands
{ 'command': 'user_def_cmd', 'data': {} }
diff --git a/tests/qapi-schema/qapi-schema-test.out b/tests/qapi-schema/qapi-schema-test.out
index 08d7304..915a61b 100644
--- a/tests/qapi-schema/qapi-schema-test.out
+++ b/tests/qapi-schema/qapi-schema-test.out
@@ -12,7 +12,7 @@
OrderedDict([('union', 'UserDefFlatUnion'), ('base', 'UserDefUnionBase'), ('discriminator', 'enum1'), ('data', OrderedDict([('value1', 'UserDefA'), ('value2', 'UserDefB'), ('value3', 'UserDefB')]))]),
OrderedDict([('union', 'UserDefFlatUnion2'), ('base', 'UserDefUnionBase'), ('discriminator', 'enum1'), ('data', OrderedDict([('value1', 'UserDefC'), ('value2', 'UserDefB'), ('value3', 'UserDefA')]))]),
OrderedDict([('union', 'UserDefAnonUnion'), ('discriminator', OrderedDict()), ('data', OrderedDict([('uda', 'UserDefA'), ('s', 'str'), ('i', 'int')]))]),
- OrderedDict([('union', 'UserDefNativeListUnion'), ('data', OrderedDict([('integer', ['int']), ('s8', ['int8']), ('s16', ['int16']), ('s32', ['int32']), ('s64', ['int64']), ('u8', ['uint8']), ('u16', ['uint16']), ('u32', ['uint32']), ('u64', ['uint64']), ('number', ['number']), ('boolean', ['bool']), ('string', ['str'])]))]),
+ OrderedDict([('union', 'UserDefNativeListUnion'), ('data', OrderedDict([('integer', ['int']), ('s8', ['int8']), ('s16', ['int16']), ('s32', ['int32']), ('s64', ['int64']), ('u8', ['uint8']), ('u16', ['uint16']), ('u32', ['uint32']), ('u64', ['uint64']), ('number', ['number']), ('boolean', ['bool']), ('string', ['str']), ('sizes', ['size'])]))]),
OrderedDict([('command', 'user_def_cmd'), ('data', OrderedDict())]),
OrderedDict([('command', 'user_def_cmd1'), ('data', OrderedDict([('ud1a', 'UserDefOne')]))]),
OrderedDict([('command', 'user_def_cmd2'), ('data', OrderedDict([('ud1a', 'UserDefOne'), ('*ud1b', 'UserDefOne')])), ('returns', 'UserDefTwo')]),
--
2.1.0
next prev parent reply other threads:[~2015-05-04 15:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 15:04 [Qemu-devel] [PATCH v8 00/40] drop qapi nested structs Eric Blake
2015-05-04 15:04 ` [Qemu-devel] [PATCH v8 01/40] qapi: Add copyright declaration on docs Eric Blake
2015-05-04 15:04 ` [Qemu-devel] [PATCH v8 02/40] qapi: Document type-safety considerations Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 03/40] qapi: Simplify builtin type handling Eric Blake
2015-05-04 15:05 ` Eric Blake [this message]
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 05/40] qapi: Require ASCII in schema Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 06/40] qapi: Add some enum tests Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 07/40] qapi: Better error messages for bad enums Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 08/40] qapi: Add some union tests Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 09/40] qapi: Clean up test coverage of simple unions Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 10/40] qapi: Forbid base without discriminator in unions Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 11/40] qapi: Tighten checking of unions Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 12/40] qapi: Prepare for catching more semantic parse errors Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 13/40] qapi: Segregate anonymous unions into alternates in generator Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 14/40] qapi: Rename anonymous union type in test Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 15/40] qapi: Document new 'alternate' meta-type Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 16/40] qapi: Use 'alternate' to replace anonymous union Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 17/40] qapi: Add some expr tests Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 18/40] qapi: Better error messages for bad expressions Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 19/40] qapi: Add tests of redefined expressions Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 20/40] qapi: Better error messages for duplicated expressions Eric Blake
2015-05-05 9:11 ` Markus Armbruster
2015-05-05 13:05 ` Eric Blake
2015-05-05 16:28 ` Markus Armbruster
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 21/40] qapi: Allow true, false and null in schema json Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 22/40] qapi: Unify type bypass and add tests Eric Blake
2015-05-04 17:42 ` Markus Armbruster
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 23/40] qapi: Add some type check tests Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 24/40] qapi: More rigourous checking of types Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 25/40] qapi: Require valid names Eric Blake
2015-05-04 17:43 ` Markus Armbruster
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 26/40] qapi: Whitelist commands that don't return dictionary Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 27/40] qapi: More rigorous checking for type safety bypass Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 28/40] qapi: Prefer 'struct' over 'type' in generator Eric Blake
2015-05-04 17:46 ` Markus Armbruster
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 29/40] qapi: Document 'struct' metatype Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 30/40] qapi: Use 'struct' instead of 'type' in schema Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 31/40] qapi: Forbid " Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 32/40] qapi: Merge UserDefTwo and UserDefNested in tests Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 33/40] qapi: Drop tests for inline nested structs Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 34/40] qapi: Drop inline nested struct in query-version Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 35/40] qapi: Drop inline nested structs in query-pci Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 36/40] qapi: Drop support for inline nested types Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 37/40] qapi: Drop dead visitor code related to nested structs Eric Blake
2015-05-04 17:57 ` Markus Armbruster
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 38/40] qapi: Tweak doc references to QMP when QGA is also meant Eric Blake
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 39/40] qapi: Support (subset of) \u escapes in strings Eric Blake
2015-05-04 18:04 ` Markus Armbruster
2015-05-04 15:05 ` [Qemu-devel] [PATCH v8 40/40] qapi: Check for member name conflicts with a base class Eric Blake
2015-05-04 18:13 ` Markus Armbruster
2015-05-04 18:19 ` [Qemu-devel] [PATCH v8 00/40] drop qapi nested structs Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430751937-17523-5-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).